-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CompatHelper: bump compat for DiffEqCallbacks to 4, (keep existing compat) #2091
base: main
Are you sure you want to change the base?
CompatHelper: bump compat for DiffEqCallbacks to 4, (keep existing compat) #2091
Conversation
36fca4c
to
85a4659
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2091 +/- ##
=======================================
Coverage 96.34% 96.34%
=======================================
Files 470 470
Lines 37512 37512
=======================================
Hits 36140 36140
Misses 1372 1372
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
The tests pass, but then again, they seem to be using DiffEqCallbacks v2.37.0. Should we merge anyways? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No. We should wait until dependencies have been updated to test the new version.
It's still using the old version, see https://github.com/trixi-framework/Trixi.jl/actions/runs/11139766106/job/30957092767?pr=2091#step:7:123 |
This pull request changes the compat entry for the
DiffEqCallbacks
package from2.25
to2.25, 4
.This keeps the compat entries for earlier versions.
Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.