Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the bad code with mixed use of variable scope #2092

Merged
merged 2 commits into from
Sep 30, 2024
Merged

Fix the bad code with mixed use of variable scope #2092

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8dfa546
fix
huiyuxie Sep 28, 2024
bc2d419
fix again
huiyuxie Sep 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion examples/tree_1d_dgsem/elixir_burgers_rarefaction.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ end
# Specify non-periodic boundary conditions

function inflow(x, t, equations::InviscidBurgersEquation1D)
return initial_condition_rarefaction(coordinate_min, t, equations)
return initial_condition_rarefaction(0.0, t, equations)
end
boundary_condition_inflow = BoundaryConditionDirichlet(inflow)
huiyuxie marked this conversation as resolved.
Show resolved Hide resolved

Expand Down
2 changes: 1 addition & 1 deletion examples/tree_1d_dgsem/elixir_burgers_shock.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ end
# Specify non-periodic boundary conditions

function inflow(x, t, equations::InviscidBurgersEquation1D)
return initial_condition_shock(coordinate_min, t, equations)
return initial_condition_shock(0.0, t, equations)
end
boundary_condition_inflow = BoundaryConditionDirichlet(inflow)
huiyuxie marked this conversation as resolved.
Show resolved Hide resolved

Expand Down
Loading