-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Level Info TreeMesh
without AMR
#2104
Level Info TreeMesh
without AMR
#2104
Conversation
Review checklistThis checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging. Purpose and scope
Code quality
Documentation
Testing
Performance
Verification
Created with ❤️ by the Trixi.jl community. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2104 +/- ##
=======================================
Coverage 96.34% 96.34%
=======================================
Files 470 470
Lines 37497 37514 +17
=======================================
+ Hits 36125 36142 +17
Misses 1372 1372
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Ok, so this prints the level information even without AMR, but if we have different levels already initially whereas before the level information was only printed with AMR, right? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. LGTM (after fixing a comment).
Motivation: Refinement patches for
TreeMesh
. Exampletree_2d_dgsem/elixir_advection_mortar.jl
.Previously:
Now: