Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.11.test vals parabolic #2114

Draft
wants to merge 13 commits into
base: hr/test_ci_julia_1_11
Choose a base branch
from

Conversation

DanielDoehring
Copy link
Contributor

No description provided.

DanielDoehring and others added 12 commits October 9, 2024 16:35
* Level Info TreeMesh without AMR

* comment

* Update src/callbacks_step/analysis.jl

* Update src/callbacks_step/analysis.jl
…rk#2062)

* remove_normal_direction_ll

* update testset name StructuredMesh3D

* fix BoundaryConditionDoNothing

* adjust docstrings

* add comment to docstring

* update test values

* add news item

---------

Co-authored-by: Daniel Doehring <[email protected]>
Co-authored-by: Hendrik Ranocha <[email protected]>
* Add velocity functions for different equations

* Formatter

* Fix CI

* Format

* Export velocity, add docs

* Export velocity, add docstring, add unit tests, make MHD velocity like 3D for all dims

* Refractor bug fixgit push

* Changes as per review

* General velocity normal function

---------

Co-authored-by: Hendrik Ranocha <[email protected]>
* start working

* get EB limiter to work

* Refine EB limiter

* fmt

* 2D/3D Limiters

* introduce parameter of tolerated entropy decrease

* change to exp_entropy_diff

* fmt

* export

* docstring

* 3d example

* exam,ples

* examples

* examples

* fmt

* adaptive

* examples

* fmt

* tests + docu

* fmt + spelling

* comment

* Apply suggestions from code review

Co-authored-by: Benjamin Bolm <[email protected]>

* Apply suggestions from code review

* increase => change

* fmt

* spelling

* revisit

* revert

* back to decrease

* fmt

* typo

* comments

* theta

* longer sim

* removed unused code

* for coverage

* Apply suggestions from code review

* longer runtime for coverage

* vals

* reproducible test values

* shorten

* changes

* testvals

* test vals

* Update src/callbacks_stage/entropy_bounded_limiter_2d.jl

* Apply suggestions from code review

* Update docs/literate/src/files/shock_capturing.jl

* more iters

* Apply suggestions from code review

* comments

* mention step_limiter! capability

* Update docs/literate/src/files/shock_capturing.jl

* Update src/callbacks_stage/entropy_bounded_limiter.jl

* Update src/callbacks_stage/entropy_bounded_limiter.jl

* Apply suggestions from code review

---------

Co-authored-by: Benjamin Bolm <[email protected]>
Copy link
Contributor

Review checklist

This checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging.

Purpose and scope

  • The PR has a single goal that is clear from the PR title and/or description.
  • All code changes represent a single set of modifications that logically belong together.
  • No more than 500 lines of code are changed or there is no obvious way to split the PR into multiple PRs.

Code quality

  • The code can be understood easily.
  • Newly introduced names for variables etc. are self-descriptive and consistent with existing naming conventions.
  • There are no redundancies that can be removed by simple modularization/refactoring.
  • There are no leftover debug statements or commented code sections.
  • The code adheres to our conventions and style guide, and to the Julia guidelines.

Documentation

  • New functions and types are documented with a docstring or top-level comment.
  • Relevant publications are referenced in docstrings (see example for formatting).
  • Inline comments are used to document longer or unusual code sections.
  • Comments describe intent ("why?") and not just functionality ("what?").
  • If the PR introduces a significant change or new feature, it is documented in NEWS.md with its PR number.

Testing

  • The PR passes all tests.
  • New or modified lines of code are covered by tests.
  • New or modified tests run in less then 10 seconds.

Performance

  • There are no type instabilities or memory allocations in performance-critical parts.
  • If the PR intent is to improve performance, before/after time measurements are posted in the PR.

Verification

  • The correctness of the code was verified using appropriate tests.
  • If new equations/methods are added, a convergence test has been run and the results
    are posted in the PR.

Created with ❤️ by the Trixi.jl community.

Copy link

codecov bot commented Oct 15, 2024

Codecov Report

Attention: Patch coverage is 81.50685% with 54 lines in your changes missing coverage. Please review.

Project coverage is 88.40%. Comparing base (480aea9) to head (689296f).
Report is 5 commits behind head on hr/test_ci_julia_1_11.

Files with missing lines Patch % Lines
src/callbacks_stage/entropy_bounded_limiter_2d.jl 0.00% 34 Missing ⚠️
...elixir_euler_colliding_flow_amr_entropy_bounded.jl 0.00% 12 Missing ⚠️
src/callbacks_stage/entropy_bounded_limiter_1d.jl 93.33% 2 Missing ⚠️
src/solvers/dgmulti/dg.jl 0.00% 2 Missing ⚠️
src/solvers/dgmulti/flux_differencing.jl 0.00% 2 Missing ⚠️
src/callbacks_stage/entropy_bounded_limiter_3d.jl 97.06% 1 Missing ⚠️
src/solvers/dgsem_unstructured/dg_2d.jl 0.00% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (480aea9) and HEAD (689296f). Click for more details.

HEAD has 3 uploads less than BASE
Flag BASE (480aea9) HEAD (689296f)
unittests 26 23
Additional details and impacted files
@@                    Coverage Diff                    @@
##           hr/test_ci_julia_1_11    #2114      +/-   ##
=========================================================
- Coverage                  96.34%   88.40%   -7.94%     
=========================================================
  Files                        470      477       +7     
  Lines                      37497    37704     +207     
=========================================================
- Hits                       36125    33331    -2794     
- Misses                      1372     4373    +3001     
Flag Coverage Δ
unittests 88.40% <81.51%> (-7.94%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DanielDoehring DanielDoehring changed the title 1.11.test vals para 1.11.test vals parabolic Oct 22, 2024
@torrilhon
Copy link
Contributor

Please note #1880 ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants