-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor modification on PairedExplicitRK3 to reduce redundant computation #2152
Minor modification on PairedExplicitRK3 to reduce redundant computation #2152
Conversation
Review checklistThis checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging. Purpose and scope
Code quality
Documentation
Testing
Performance
Verification
Created with ❤️ by the Trixi.jl community. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2152 +/- ##
=======================================
Coverage 96.36% 96.36%
=======================================
Files 480 480
Lines 38069 38069
=======================================
Hits 36684 36684
Misses 1385 1385
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This PR removes redundant computations of c in
TrixiNLsolveExt.jl
for the current implementation ofPairedExplicitRK3
. Sincec
is already computed and passed to the function in the extension file, recalculating it is unnecessary.This change also simplifies future adjustments where different sets of abscissae c might be needed.
Please let me know if there are any further improvements or changes needed!