-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Similiarize Structured1D
to Tree1D
#2153
Similiarize Structured1D
to Tree1D
#2153
Conversation
Review checklistThis checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging. Purpose and scope
Code quality
Documentation
Testing
Performance
Verification
Created with ❤️ by the Trixi.jl community. |
Structured1D
to Tree1D
Structured1D
to Tree1D
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2153 +/- ##
=======================================
Coverage 96.36% 96.36%
=======================================
Files 480 480
Lines 38067 38069 +2
=======================================
+ Hits 36682 36684 +2
Misses 1385 1385
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
For 1D
TreeMeshes
, the user can specify the coordinates as a tuple(1.0)
or as a Float:1.0
. This was not possible for 1DStructuredMesh
. Loosely related to #1194