Restart HyperbolicParabolic with SplitODEProblem

[DanielDoehring]

Previously, when restarting a parabolic semidiscretization only a standard ODEProblem would be constructed, completely neglecting the rhs_prabolic!. This takes care of this bug.

[github-actions]

Review checklist

This checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging.

Purpose and scope

• The PR has a single goal that is clear from the PR title and/or description.
• All code changes represent a single set of modifications that logically belong together.
• No more than 500 lines of code are changed or there is no obvious way to split the PR into multiple PRs.

Code quality

• The code can be understood easily.
• Newly introduced names for variables etc. are self-descriptive and consistent with existing naming conventions.
• There are no redundancies that can be removed by simple modularization/refactoring.
• There are no leftover debug statements or commented code sections.
• The code adheres to our conventions and style guide, and to the Julia guidelines.

Documentation

• New functions and types are documented with a docstring or top-level comment.
• Relevant publications are referenced in docstrings (see example for formatting).
• Inline comments are used to document longer or unusual code sections.
• Comments describe intent ("why?") and not just functionality ("what?").
• If the PR introduces a significant change or new feature, it is documented in NEWS.md with its PR number.

Testing

• The PR passes all tests.
• New or modified lines of code are covered by tests.
• New or modified tests run in less then 10 seconds.

Performance

• There are no type instabilities or memory allocations in performance-critical parts.
• If the PR intent is to improve performance, before/after time measurements are posted in the PR.

Verification

• The correctness of the code was verified using appropriate tests.
• If new equations/methods are added, a convergence test has been run and the results
  are posted in the PR.

Created with ❤️ by the Trixi.jl community.

[JoshuaLampert]

IIRC, you said this is technically breaking? Before this would have simply give an error, right? Or would currently working code behave differently in any way?

[DanielDoehring]

IIRC, you said this is technically breaking? Before this would have simply give an error, right? Or would currently working code behave differently in any way?

So you would get no error, but just a simulation with the hyperbolic part only.

[JoshuaLampert]

IIRC, you said this is technically breaking? Before this would have simply give an error, right? Or would currently working code behave differently in any way?

So you would get no error, but just a simulation with the hyperbolic part only.

Ah, the previous semidiscretize with restart_file dispatches on AbstractSemidiscretization, not on SemidiscretizationHyperbolic. Makes sense. So yes, this changes currently running code. But since it's a bug fix as you definitely don't want to run the simulation with the hyperbolic part only, it's fine as discussed in the meeting. Thanks for the clarification.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.36%. Comparing base (7f6a860) to head (b446b9d).
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #2156   +/-   ##
=======================================
  Coverage   96.36%   96.36%           
=======================================
  Files         480      480           
  Lines       38069    38075    +6     
=======================================
+ Hits        36684    36690    +6     
  Misses       1385     1385           

Flag	Coverage Δ
unittests	96.36% <100.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[JoshuaLampert]

Thanks!

[DanielDoehring]

@JoshuaLampert Just ping me for the "semicolon removal" PR addressing #2156 (comment)