Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable GPU compatibility check in CI #2168

Merged
merged 13 commits into from
Dec 3, 2024
Merged

Conversation

huiyuxie
Copy link
Member

@huiyuxie huiyuxie commented Nov 19, 2024

This workflow will pass for Julia 1.10 but fail for Julia 1.11 so I restrict the test only to 1.10

Copy link
Contributor

Review checklist

This checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging.

Purpose and scope

  • The PR has a single goal that is clear from the PR title and/or description.
  • All code changes represent a single set of modifications that logically belong together.
  • No more than 500 lines of code are changed or there is no obvious way to split the PR into multiple PRs.

Code quality

  • The code can be understood easily.
  • Newly introduced names for variables etc. are self-descriptive and consistent with existing naming conventions.
  • There are no redundancies that can be removed by simple modularization/refactoring.
  • There are no leftover debug statements or commented code sections.
  • The code adheres to our conventions and style guide, and to the Julia guidelines.

Documentation

  • New functions and types are documented with a docstring or top-level comment.
  • Relevant publications are referenced in docstrings (see example for formatting).
  • Inline comments are used to document longer or unusual code sections.
  • Comments describe intent ("why?") and not just functionality ("what?").
  • If the PR introduces a significant change or new feature, it is documented in NEWS.md with its PR number.

Testing

  • The PR passes all tests.
  • New or modified lines of code are covered by tests.
  • New or modified tests run in less then 10 seconds.

Performance

  • There are no type instabilities or memory allocations in performance-critical parts.
  • If the PR intent is to improve performance, before/after time measurements are posted in the PR.

Verification

  • The correctness of the code was verified using appropriate tests.
  • If new equations/methods are added, a convergence test has been run and the results
    are posted in the PR.

Created with ❤️ by the Trixi.jl community.

@huiyuxie huiyuxie requested a review from ranocha November 19, 2024 06:35
Copy link

codecov bot commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.39%. Comparing base (5db379b) to head (9b5f01c).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2168   +/-   ##
=======================================
  Coverage   96.39%   96.39%           
=======================================
  Files         483      483           
  Lines       38325    38325           
=======================================
  Hits        36941    36941           
  Misses       1384     1384           
Flag Coverage Δ
unittests 96.39% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@huiyuxie
Copy link
Member Author

I need thorough tests on all available OS x architecture. This will increase CI time, but it is necessary to ensure compatibility across all available resources.

@huiyuxie
Copy link
Member Author

Review please @ranocha Thanks!

.github/workflows/GPUCompat.yml Outdated Show resolved Hide resolved
.github/workflows/GPUCompat.yml Show resolved Hide resolved
@huiyuxie huiyuxie added the gpu label Nov 20, 2024
@huiyuxie
Copy link
Member Author

Is it really? You just activate an empty temporary environment and add CUDA.jl to it, so it does not do anything with Trixi.jl, does it?

Yes 😥 - I aimed to create an independent environment for each but forgot it is empty.

@huiyuxie huiyuxie requested a review from ranocha November 20, 2024 21:29
@huiyuxie
Copy link
Member Author

Is the codecov issue fixed? The CI looks quite normal to me

@huiyuxie
Copy link
Member Author

huiyuxie commented Nov 21, 2024

May I ask why we do not include tests for the 32 bit archs in the general CI? - Julia supports 32 bit on Linux and Windows

@ranocha
Copy link
Member

ranocha commented Nov 27, 2024

May I ask why we do not include tests for the 32 bit archs in the general CI? - Julia supports 32 bit on Linux and Windows

The platforms are not used very often. Testing them in detail would add a huge amount of additional CI time.

Copy link
Member

@ranocha ranocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

Copy link
Member

@ranocha ranocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just noticed this - the name can be misleading since it does not perform any GPU compatibility tests running simulation etc.

.github/workflows/GPUCompat.yml Outdated Show resolved Hide resolved
@huiyuxie huiyuxie requested a review from ranocha November 29, 2024 04:05
@ranocha ranocha merged commit abe8640 into trixi-framework:main Dec 3, 2024
36 of 38 checks passed
@huiyuxie huiyuxie deleted the compat branch December 3, 2024 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants