-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modification on PERK time integrator to handle cases where s = e #2177
Modification on PERK time integrator to handle cases where s = e #2177
Conversation
Review checklistThis checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging. Purpose and scope
Code quality
Documentation
Testing
Performance
Verification
Created with ❤️ by the Trixi.jl community. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2177 +/- ##
==========================================
- Coverage 96.37% 96.36% -0.00%
==========================================
Files 480 480
Lines 38225 38230 +5
==========================================
+ Hits 36837 36840 +3
- Misses 1388 1390 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking care of this so quick!
If the user enters the number of stages 2 and 3 to
PairedExplicitRK2
andPairedExplicitRK3
, an error pops up since the integrator wasn't coded to handle the cases with no gamma to optimize. With this PR, this is handled. Thebisect_stability_polynomial
will return nothing, anddt_opt
will be obtained from the bisection if the number of stages input by the user is equal to the consistency order of the time integration scheme.Please let me know if you'd like anything changed!