Use Adapt.jl to change storage and element type #2212
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to eventually support GPU computation we need
to use Adapt.jl to allow GPU backend packages to swap
out host-array types like `CuArray` with device-side types
like `CuDeviceArray`.
Additionally this will allow us to change the element type
of a simulation by using `adapt(Array{Float32}`.
Co-authored-by: Lars Christmann <[email protected]>
Co-authored-by: Benedict Geihe <[email protected]>
Review checklistThis checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging. Purpose and scope
Code quality
Documentation
Testing
Performance
Verification
Created with ❤️ by the Trixi.jl community. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Comment on lines
+40
to
45
| performance_counter::PerformanceCounter) where {Mesh, Equations, | ||
| InitialCondition, | ||
| BoundaryConditions, | ||
| SourceTerms, | ||
| Solver, | ||
| Cache} |
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| performance_counter::PerformanceCounter) where {Mesh, Equations, | |
| InitialCondition, | |
| BoundaryConditions, | |
| SourceTerms, | |
| Solver, | |
| Cache} | |
| performance_counter::PerformanceCounter) where { | |
| Mesh, | |
| Equations, | |
| InitialCondition, | |
| BoundaryConditions, | |
| SourceTerms, | |
| Solver, | |
| Cache | |
| } |
| SemidiscretizationHyperbolic{typeof(mesh), typeof(equations), | ||
| typeof(initial_condition), | ||
| typeof(_boundary_conditions), typeof(source_terms), | ||
| typeof(solver), typeof(cache)}(mesh, equations, | ||
| initial_condition, | ||
| _boundary_conditions, | ||
| source_terms, solver, | ||
| cache) | ||
| cache, performance_counter) |
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| cache, performance_counter) | |
| cache, | |
| performance_counter) |
| initial_condition, | ||
| boundary_conditions, | ||
| source_terms, solver, | ||
| cache, performance_counter) |
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| cache, performance_counter) | |
| cache, | |
| performance_counter) |
| _contravariant_vectors = Adapt.adapt_structure(to, elements._contravariant_vectors) | ||
| _inverse_jacobian = Adapt.adapt_structure(to, elements._inverse_jacobian) | ||
| _surface_flux_values = Adapt.adapt_structure(to, elements._surface_flux_values) | ||
|
|
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
Comment on lines
+308
to
+309
| neighbor_ids = unsafe_wrap_or_alloc(to, _neighbor_ids, size(interfaces.neighbor_ids)) | ||
| node_indices = unsafe_wrap_or_alloc(to, _node_indices, size(interfaces.node_indices)) |
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| neighbor_ids = unsafe_wrap_or_alloc(to, _neighbor_ids, size(interfaces.neighbor_ids)) | |
| node_indices = unsafe_wrap_or_alloc(to, _node_indices, size(interfaces.node_indices)) | |
| neighbor_ids = unsafe_wrap_or_alloc(to, _neighbor_ids, | |
| size(interfaces.neighbor_ids)) | |
| node_indices = unsafe_wrap_or_alloc(to, _node_indices, | |
| size(interfaces.node_indices)) |
| neighbor_ids = unsafe_wrap_or_alloc(to, _neighbor_ids, size(mortars.neighbor_ids)) | ||
| node_indices = unsafe_wrap_or_alloc(to, _node_indices, size(mortars.node_indices)) | ||
|
|
||
|
|
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| _u, _node_indices, | ||
| _normal_directions) | ||
| NDIMS + 3, typeof(u), | ||
| typeof(_u), |
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| typeof(_u), | |
| typeof(_u), |
| @@ -5,12 +5,12 @@ | |||
| @muladd begin | |||
| #! format: noindent | |||
|
|
|||
| mutable struct P4estMPICache{uEltype} | |||
| mutable struct P4estMPICache{BufferType <: DenseVector, VecInt <: DenseVector{<:Integer}} | |||
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| mutable struct P4estMPICache{BufferType <: DenseVector, VecInt <: DenseVector{<:Integer}} | |
| mutable struct P4estMPICache{BufferType <: DenseVector, | |
| VecInt <: DenseVector{<:Integer}} |
|
|
||
| function Adapt.adapt_structure(to, mpi_cache::P4estMPICache) | ||
| mpi_neighbor_ranks = mpi_cache.mpi_neighbor_ranks | ||
| mpi_neighbor_interfaces = Adapt.adapt_structure(to, mpi_cache.mpi_neighbor_interfaces) |
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| mpi_neighbor_interfaces = Adapt.adapt_structure(to, mpi_cache.mpi_neighbor_interfaces) | |
| mpi_neighbor_interfaces = Adapt.adapt_structure(to, | |
| mpi_cache.mpi_neighbor_interfaces) |
| @assert eltype(mpi_send_buffers) == eltype(mpi_recv_buffers) | ||
| BufferType = eltype(mpi_send_buffers) | ||
| VecInt = eltype(mpi_neighbor_interfaces) | ||
| return P4estMPICache{BufferType, VecInt}(mpi_neighbor_ranks, mpi_neighbor_interfaces, |
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| return P4estMPICache{BufferType, VecInt}(mpi_neighbor_ranks, mpi_neighbor_interfaces, | |
| return P4estMPICache{BufferType, VecInt}(mpi_neighbor_ranks, | |
| mpi_neighbor_interfaces, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to eventually support GPU computation we need
to use Adapt.jl to allow GPU backend packages to swap
out host-array types like
CuArraywith device-side typeslike
CuDeviceArray.Additionally this will allow us to change the element type
of a simulation by using
adapt(Array{Float32}.Co-authored-by: Lars Christmann [email protected]
Co-authored-by: Benedict Geihe [email protected]