-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 3D multi-ion GLM-MHD equations for the TreeMesh solver #2215
base: main
Are you sure you want to change the base?
Conversation
Review checklistThis checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging. Purpose and scope
Code quality
Documentation
Testing
Performance
Verification
Created with ❤️ by the Trixi.jl community. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2215 +/- ##
==========================================
+ Coverage 96.37% 96.42% +0.05%
==========================================
Files 486 487 +1
Lines 39186 39761 +575
==========================================
+ Hits 37764 38337 +573
- Misses 1422 1424 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Impressive work! I really do not want to imagine debugging this 💀 :D
prim[3] = 1 | ||
for k in eachcomponent(equations) | ||
set_component!(prim, k, | ||
2^(k - 1) * (1 - 2) / (1 - 2^ncomponents(equations)) * rho, v1, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it make sense to extract this, i.e.,
2^(k - 1) * (1 - 2) / (1 - 2^ncomponents(equations)) * rho
into an own variable with a descriptive name such that one has an idea what is going on here?
(rho_e - 0.5f0 * rho * v_mag^2 - 0.5f0 * (B1^2 + B2^2 + B3^2) - | ||
0.5f0 * psi^2) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a little inconsistent as there is v_mag
but no B_mag
.
This PR introduces the 3D multi-ion GLM-MHD equations. The implementation closely follows the 2D implementation (#2196), with the main difference being the inclusion of fluxes, non-conservative terms, and wave speeds for
orientation == 3
.