remove restriction of DiffEqBase.jl (used as hotfix)

[ranocha]

Closes #1789, closes #1785, closes #1240, closes #2108, closes #2120, closes #2121, closes #2157, closes #1791, closes #1850, closes #2091.

[github-actions]

Review checklist

This checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging.

Purpose and scope

• The PR has a single goal that is clear from the PR title and/or description.
• All code changes represent a single set of modifications that logically belong together.
• No more than 500 lines of code are changed or there is no obvious way to split the PR into multiple PRs.

Code quality

• The code can be understood easily.
• Newly introduced names for variables etc. are self-descriptive and consistent with existing naming conventions.
• There are no redundancies that can be removed by simple modularization/refactoring.
• There are no leftover debug statements or commented code sections.
• The code adheres to our conventions and style guide, and to the Julia guidelines.

Documentation

• New functions and types are documented with a docstring or top-level comment.
• Relevant publications are referenced in docstrings (see example for formatting).
• Inline comments are used to document longer or unusual code sections.
• Comments describe intent ("why?") and not just functionality ("what?").
• If the PR introduces a significant change or new feature, it is documented in NEWS.md with its PR number.

Testing

• The PR passes all tests.
• New or modified lines of code are covered by tests.
• New or modified tests run in less then 10 seconds.

Performance

• There are no type instabilities or memory allocations in performance-critical parts.
• If the PR intent is to improve performance, before/after time measurements are posted in the PR.

Verification

• The correctness of the code was verified using appropriate tests.
• If new equations/methods are added, a convergence test has been run and the results
  are posted in the PR.

Created with ❤️ by the Trixi.jl community.

[JoshuaLampert]

In #2263 (comment) I made a list of issues and PRs, which are closed by this PR.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.87%. Comparing base (ce4f75d) to head (4a682ff).
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #2264   +/-   ##
=======================================
  Coverage   96.87%   96.87%           
=======================================
  Files         490      490           
  Lines       39485    39491    +6     
=======================================
+ Hits        38248    38255    +7     
+ Misses       1237     1236    -1     

Flag	Coverage Δ
unittests	96.87% <100.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[JoshuaLampert]

Probably bump Reexport.jl to v1.2 to allow newer versions of NonlinearSolve.jl?

[JoshuaLampert]

I'll try to locally debug the Downgrade compat stuff.

[ranocha]

Thanks a lot!

[ranocha]

Thanks a lot, @JoshuaLampert! Could you please review this PR so that we can merge it when CI passes?

[JoshuaLampert]

Yes, we still have some errors. I'll look into them.

[ranocha]

Failing invalidations CI is fine with me

[JoshuaLampert]

Let's collect the errors we have in CI:

• https://github.com/trixi-framework/Trixi.jl/actions/runs/13197952897/job/36843340041?pr=2264#step:7:2221

  LoadError: MethodError: no method matching get_tstops_max(
  

• Some test values need to be adjusted:
  • https://github.com/trixi-framework/Trixi.jl/actions/runs/13197952897/job/36843340041?pr=2264#step:7:4265
  • https://github.com/trixi-framework/Trixi.jl/actions/runs/13197952897/job/36843340041?pr=2264#step:7:20526,
  • https://github.com/trixi-framework/Trixi.jl/actions/runs/13197952897/job/36843340041?pr=2264#step:7:20742
  • https://github.com/trixi-framework/Trixi.jl/actions/runs/13197952897/job/36843343720#step:7:873
  • https://github.com/trixi-framework/Trixi.jl/actions/runs/13197952897/job/36843343720#step:7:6160
  • https://github.com/trixi-framework/Trixi.jl/actions/runs/13197952897/job/36843344244#step:7:902
  • https://github.com/trixi-framework/Trixi.jl/actions/runs/13197952897/job/36843344244#step:7:1516
  • https://github.com/trixi-framework/Trixi.jl/actions/runs/13200117195/job/36849999785?pr=2264#step:7:1254
• https://github.com/trixi-framework/Trixi.jl/actions/runs/13197952897/job/36843345479?pr=2264#step:7:6553

  Stale dependencies: Test Failed at /home/runner/.julia/packages/Aqua/epbUr/src/stale_deps.jl:31
  Expression: isempty(stale_deps)
  Evaluated: isempty(Base.PkgId[StableRNGs [860ef19b-820b-49d6-a774-d7a799459cd3]])
  
  Stacktrace:
  [1] macro expansion
  @ /opt/hostedtoolcache/julia/1.10.8/x64/share/julia/stdlib/v1.10/Test/src/Test.jl:672 [inlined]
  [2] test_stale_deps(pkg::Base.PkgId; kwargs::@Kwargs{})
  @ Aqua ~/.julia/packages/Aqua/epbUr/src/stale_deps.jl:31
  

• https://github.com/trixi-framework/Trixi.jl/actions/runs/13197952897/job/36843344244#step:7:1119

  LoadError: unable to determine if out/restart_000000018.h5 is accessible in the HDF5 format (file may not exist)
  

• https://github.com/trixi-framework/Trixi.jl/actions/runs/13200117205/job/36849994393?pr=2264#step:7:3488
• Compat bounds in TrixiShallowWater.jl need to be adjusted according to the ones here, cf. Bump compat bounds according to Trixi.jl TrixiShallowWater.jl#68.
• In TrixiShallowWater.jl (probably fixed after merging Add flexibility to nonconservative BCs #2200)

[ranocha]

I will look at the

LoadError: MethodError: no method matching get_tstops_max(

error. Could you please check the second and third items on the list?

[JoshuaLampert]

Ok, looks like Downgrade is finally happy. These SciML packages always need pretty high compat bounds... Now, we only need to fix the compat bounds in TrixiShallowWater.jl according to the ones here.

[JoshuaLampert]

@ranocha, can you comment on the circular dependency including TrixiDiffEqBaseExt.jl (https://github.com/trixi-framework/Trixi.jl/actions/runs/13200117204/job/36849978148?pr=2264#step:8:530)?

[JoshuaLampert]

@DanielDoehring, can you please confirm that eb3d778 is the correct fix for https://github.com/trixi-framework/Trixi.jl/actions/runs/13200117205/job/36849994393?pr=2264#step:7:3488? Do you know why this error wasn't thrown before?

[ranocha]

@ranocha, can you comment on the circular dependency including TrixiDiffEqBaseExt.jl (https://github.com/trixi-framework/Trixi.jl/actions/runs/13200117204/job/36849978148?pr=2264#step:8:530)?

See dd81e82

[JoshuaLampert]

@ranocha, can you comment on the circular dependency including TrixiDiffEqBaseExt.jl (https://github.com/trixi-framework/Trixi.jl/actions/runs/13200117204/job/36849978148?pr=2264#step:8:530)?

See dd81e82

Thanks!