Add capability to not perform reinterpolation #57

andrewwinters5000 · 2022-11-24T07:08:56Z

This adds the feature that Trixi2Vtk can convert h5 output files into vtu files but keep the solution data on the original grid used for computation. This should work for the DG solver as well as FDSBP.

Update: This PR also completely restructures how the testing is done. It is more stable now and no longer relies on comparing hashes which caused a lot of headaches (see here for details). Reference data files are pulled from the new repository Trixi2Vtk_reference_files.

…ormat

…rom external repo

sloede

Sorry for being so late about it. This is not a full review, but I am in a meeting and I wanted to relay what I have already looked at. Will continue later!

src/convert.jl

ranocha

Looks great! I just have some minor suggestions

src/convert.jl

test/test_2d.jl

src/convert.jl

test/test_2d.jl

test/test_3d.jl

sloede

Great work! Many people will by grateful to you in the future for this much-needed improvement of the testing system 👍👍 I left a number of comments, some of which are really just suggestions (feel free to skip those you do not feel worth adressing)

src/convert.jl

src/vtktools.jl

test/test_trixi2vtk.jl

Co-authored-by: Hendrik Ranocha <[email protected]> Co-authored-by: Michael Schlottke-Lakemper <[email protected]>

…r the mesh conversion

… into convert-raw

andrewwinters5000 · 2022-12-16T07:39:52Z

Great work! Many people will by grateful to you in the future for this much-needed improvement of the testing system

I assume you are one such person 😉

ranocha

🥳

sloede

LGTM! Thanks!

src/vtktools.jl

add flags and capability to convert the raw solution data into vtu f…

258de35

…ormat

andrewwinters5000 added the enhancement New feature or request label Nov 24, 2022

ranocha mentioned this pull request Nov 25, 2022

update CI to Julia v1.7 and fix tests #58

Merged

Merge branch 'main' into convert-raw

21fe1ac

ranocha mentioned this pull request Nov 28, 2022

Upwind finite difference SBP solver trixi-framework/Trixi.jl#1275

Merged

4 tasks

Merge branch 'main' into convert-raw

cadfbff

ranocha mentioned this pull request Nov 30, 2022

upwind tutorial trixi-framework/Trixi.jl#1283

Merged

andrewwinters5000 added 20 commits December 1, 2022 08:44

simplify how raw data is copied

2a4b617

working version across all mesh types

09fe034

Merge branch 'main' into convert-raw

dc3ecc3

rearrange to fix setting incorrect nvisnodes

aaab1d1

add tests using ReadVTK instead of comparing hashes

0127d98

for now add the reference files to this repo. possibly change

0a55363

remove reference files from repo

6c59553

update all 2d tests. pass locally

6d8da8d

update the testing functions

9eb67d3

remove unnecessary code

95c0019

remove extra space

42c9660

adjust default setting for the mesh visualization

e2b3323

new battery of 3D tests. All pass locally

5120881

update 2D tests to grab files from Trixi2Vtk_reference_files repo

42f2340

add a delete of the local reference files folder

ec176e1

ignore the reference_files folder

699b5cf

update 3D tests to grab files from Trixi2Vtk_reference_files repo

7be6b50

remove unused dependency

cb545a8

introduce new testing functions and ability to grab reference files f…

9dd56e4

…rom external repo

forgot to update a docstring

bc408d8

ranocha mentioned this pull request Dec 2, 2022

Finish upwind SBP implementation trixi-framework/Trixi.jl#1284

Open

8 tasks

andrewwinters5000 added 2 commits December 3, 2022 18:28

remove need for artifacts folder

d779e50

reorganize new tests and clarify filenames.

b9b62ad

andrewwinters5000 added 4 commits December 8, 2022 08:51

put VTI output routines back in

db9d2c7

add error message if output format and mesh type are incompatible

f071a55

update test reference files tag and add new VTI tests

95e260d

typo fix

17c33c5

andrewwinters5000 requested review from sloede and ranocha December 8, 2022 10:37

andrewwinters5000 added 2 commits December 15, 2022 14:16

remove unnecessary comments

77e2f72

improve logic for format and mesh check

c7a0f7c

sloede reviewed Dec 15, 2022

View reviewed changes

src/convert.jl Show resolved Hide resolved

src/convert.jl Outdated Show resolved Hide resolved

remove empty nodeset declaration

054c0ca

ranocha requested changes Dec 15, 2022

View reviewed changes

sloede reviewed Dec 15, 2022

View reviewed changes

Apply suggestions from code review

2150dff

Co-authored-by: Hendrik Ranocha <[email protected]> Co-authored-by: Michael Schlottke-Lakemper <[email protected]>

andrewwinters5000 linked an issue Dec 16, 2022 that may be closed by this pull request

Keep VTI format? #60

Closed

andrewwinters5000 added 7 commits December 16, 2022 07:12

add missing header tests to cell data function

a676f0c

adjust node_set creation and revert function to set the n_visnodes fo…

e071b22

…r the mesh conversion

VTI format check only applies to TreeMesh{2}

b98bdbb

make sure that node_set is always the same type

aaaabc6

name change compare_cell_info -> compare_cell_data

2aa5532

name change compare_point_info -> compare_point_data

67a3eb8

remove unnecessary spaces

c7667c6

andrewwinters5000 requested review from ranocha and sloede December 16, 2022 07:32

andrewwinters5000 added 2 commits December 16, 2022 08:33

remove unnecessary spaces

ab0617f

Merge branch 'convert-raw' of github.com:trixi-framework/Trixi2Vtk.jl…

a6e4104

… into convert-raw

ranocha approved these changes Dec 16, 2022

View reviewed changes

sloede approved these changes Dec 16, 2022

View reviewed changes

src/vtktools.jl Outdated Show resolved Hide resolved

sloede merged commit 2170dee into main Dec 16, 2022

sloede deleted the convert-raw branch December 16, 2022 12:41

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add capability to not perform reinterpolation #57

Add capability to not perform reinterpolation #57

andrewwinters5000 commented Nov 24, 2022 •

edited

Loading

sloede left a comment

ranocha left a comment

sloede left a comment

andrewwinters5000 commented Dec 16, 2022

ranocha left a comment

sloede left a comment

Add capability to not perform reinterpolation #57

Add capability to not perform reinterpolation #57

Conversation

andrewwinters5000 commented Nov 24, 2022 • edited Loading

sloede left a comment

Choose a reason for hiding this comment

ranocha left a comment

Choose a reason for hiding this comment

sloede left a comment

Choose a reason for hiding this comment

andrewwinters5000 commented Dec 16, 2022

ranocha left a comment

Choose a reason for hiding this comment

sloede left a comment

Choose a reason for hiding this comment

andrewwinters5000 commented Nov 24, 2022 •

edited

Loading