Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update rotor reference files #5

Merged
merged 1 commit into from
Oct 30, 2024
Merged

Update rotor reference files #5

merged 1 commit into from
Oct 30, 2024

Conversation

andrewwinters5000
Copy link
Member

The fix to the computation of the nonconservative terms at mortars trixi-framework/Trixi.jl#2134 requires an update to the rotor solution reference.

ranocha
ranocha approved these changes Oct 30, 2024
View reviewed changes
Copy link
Member

@ranocha ranocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! The next step is to

  • merge the Trixi.jl PR
  • update the reference file repo commit hash and tests in Trixi2Vtk.jl

@ranocha ranocha merged commit e51f361 into main Oct 30, 2024
@ranocha ranocha deleted the update_rotor_reference branch October 30, 2024 08:17
@andrewwinters5000
Copy link
Member Author

Okay, I can make a PR into Trixi2Vtk.jl directly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ranocha ranocha ranocha approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andrewwinters5000 @ranocha