Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Andrés Rueda-Ramírez <[email protected]>
  • Loading branch information
tristanmontoya and amrueda authored Jan 29, 2025
1 parent 51ac25d commit 7b0f2cc
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions src/equations/covariant_shallow_water_split.jl
Original file line number Diff line number Diff line change
Expand Up @@ -50,11 +50,12 @@ struct SplitCovariantShallowWaterEquations2D{GlobalCoordinateSystem, RealT <: Re
end
end

# Until we implement bottom topography, there are no nonconservative terms
# This alternative flux formulation has non-conservative terms even in the absence of variable bottom topography
Trixi.have_nonconservative_terms(::SplitCovariantShallowWaterEquations2D) = True()

# Flux as a function of the state vector u, as well as the auxiliary variables aux_vars,
# which contain the geometric information required for the covariant form
# which contain the geometric information required for the covariant form.
# Note that this flux does not include the pressure term.
@inline function Trixi.flux(u, aux_vars, orientation::Integer,
equations::SplitCovariantShallowWaterEquations2D)
# Geometric variables
Expand Down

0 comments on commit 7b0f2cc

Please sign in to comment.