-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mixed kernel gradient #261
Merged
efaulhaber
merged 106 commits into
trixi-framework:main
from
svchb:mixed-kernel-gradient
Jan 5, 2024
+653
−205
Merged
Changes from all commits
Commits
Show all changes
106 commits
Select commit
Hold shift + click to select a range
57382e2
add gradient correction stuff
svchb 81449fb
impl
svchb 63f5ac9
up
svchb cfaf96c
finish impl
svchb 4bf647e
update
svchb e937e15
fix testcases
svchb 7c131db
fix
svchb 1f53431
fix tests
svchb af8af78
format
svchb 901d189
Merge branch 'main' into mixed-kernel-gradient
svchb 182a872
working
svchb 3cf34f4
format
svchb 2e67efe
Merge branch 'main'
svchb 027b1a4
format
svchb 5f4a925
fix
svchb ad42394
working trixi_include
svchb 8612c82
Merge branch 'main'
svchb 09a1ea4
fix
svchb cadbbba
cleanup
svchb 01a4173
format
svchb b506359
fix
svchb 89cb149
fix tests
svchb f1537c4
Merge branch 'main'
svchb 2cae13f
fix
svchb 36ee614
Merge branch 'main' into mixed-kernel-gradient
svchb 1cffc70
ups
svchb 5d57d97
Merge branch 'mixed-kernel-gradient' of github.com:svchb/TrixiParticl…
svchb 0e75ef2
typo
svchb 2b03fe9
up
svchb 1548433
fix
svchb ae78667
format
svchb 54e7c16
update fix errors
svchb 47ed721
fix
svchb 57c55f1
update
svchb 76aefea
up
svchb 5c4d20d
fix tests
svchb c7976f9
fix tests
svchb aa66268
np
svchb 369cbc9
remove comment
svchb 7799f62
revert some changes
svchb d7932ca
up
svchb cc075f5
Merge branch 'main'
svchb e5e1ed9
up
svchb 001668a
Merge branch 'main' into mixed-kernel-gradient
svchb 40c567f
update
svchb 95dcc62
format
svchb c8a67e7
Merge branch 'mixed-kernel-gradient' of github.com:svchb/TrixiParticl…
svchb 30f7c32
cleanup
svchb ac76b86
revert
svchb 67ea62d
revert
svchb ae6b3eb
implement correction on wall
svchb 057adbe
fix tests
svchb bc9b87e
fix pressure_acceleration for summation
svchb 21b83d5
format
svchb 96b18c9
revert
svchb 10d1a47
fix
svchb ca7f106
Merge branch 'main'
svchb 7126cce
fixes
svchb f5469da
fix
svchb 47f824d
fix pressure_acceleration dispatches
svchb 3af1309
typo
svchb 1b5d137
fix
svchb acafbe1
rename
svchb 6ae8528
Merge branch 'main' into mixed-kernel-gradient
svchb 1e47bc9
Merge branch 'main' into mixed-kernel-gradient
svchb d9d9562
some review fixes
svchb be802d4
review
svchb 9278edb
more fixes
svchb f54c891
add solid system type
svchb 3ed56be
review
svchb 72d293f
fix tlsph call
svchb 7b0c438
fix comment
svchb 1a4803c
review
svchb 3aea7ae
review
svchb 2316101
format
svchb b4c3ad6
review
svchb 2ab5853
move
svchb 49b72f3
fix doc
svchb e2b9574
review fix
svchb 148c0e9
more review
svchb 2c86a03
review fix
svchb 54b3fa0
format
svchb 26e90b1
change parameter list
svchb 824a054
reorder params
svchb 76a5673
Merge branch 'main' into mixed-kernel-gradient
svchb 390e0ed
format
svchb b3d3924
fix
svchb 33ce59a
fix
svchb 3346c63
Merge branch 'mixed-kernel-gradient' of github.com:svchb/TrixiParticl…
svchb 22a6ff5
fix
svchb 40805b5
remove dispatched functions
svchb ea17c79
format
svchb 9e162ca
fix comments
svchb ae069d2
fix
svchb 8fb3323
remove system
svchb c5803fd
format
svchb 4f5223f
change parameter list
svchb 111c53c
review
svchb be15f26
unused variable
svchb 7886cf9
break
svchb 2a332b9
edit todo
svchb 240f1c8
remove breaks
svchb 0b98a52
format
svchb 2e6fcd7
Merge branch 'main' into mixed-kernel-gradient
svchb 451f3d4
rename grad_kernel to W_a
svchb 1c152c9
Merge branch 'mixed-kernel-gradient' of github.com:svchb/TrixiParticl…
svchb File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this maybe also be moved to be passed as a kwarg to
trixi_include
in the corrections example, as it is only needed with corrections and might affect the runtime of the uncorrected example?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Its 4% slower with the smaller dtmax.