Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise initial condition and shapes API #335

Merged
merged 7 commits into from
Jan 11, 2024

Merge branch 'main' into ic-pointwise-quantities

ac9a09e
Select commit
Loading
Failed to load commit list.
Merged

Revise initial condition and shapes API #335

Merge branch 'main' into ic-pointwise-quantities
ac9a09e
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 11, 2024 in 0s

70.55% (+0.32%) compared to 8521359

View this Pull Request on Codecov

70.55% (+0.32%) compared to 8521359

Details

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (8521359) 70.22% compared to head (ac9a09e) 70.55%.

Files Patch % Lines
src/setups/rectangular_shape.jl 76.92% 3 Missing ⚠️
src/setups/rectangular_tank.jl 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #335      +/-   ##
==========================================
+ Coverage   70.22%   70.55%   +0.32%     
==========================================
  Files          53       54       +1     
  Lines        3228     3267      +39     
==========================================
+ Hits         2267     2305      +38     
- Misses        961      962       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.