Fix acknowledgement logos in readme #427
Conversation
|
For some reason, the links stop working after some time (minutes/hours). |
|
Of course, we can just use the Trixi issue to host our images as well, but we also want to host images for the docs, so it would be nice if we could fix that problem here. |
Seems fixed in #438, or not? I now get something like `https://github-production-user-asset-6210df.s3.amazonaws.com/44124897/310171141-05132bf1-180f-4228-b30a-37dfb6e36ed5.png?``` for the hereon logo, for example |
|
Okay, I think I know what's going on now. I think GitHub changed the way they store assets. I was looking at the first posts in trixi-framework/Trixi.jl#1390, where the posted link is the same as the "copy image address" URL. In the later posts, that changed to |
|
Ah yes, I didn't remember to tell you that I played around with this before and found that each time the picture URL is accessed, it is actually resolved to something else. You need to use the asset URL that is stored in Markdown, not the (temporary) resolved URL when linking to that image. |
| [](https://trixi-framework.github.io/TrixiParticles.jl/stable) | ||
| [](https://trixi-framework.github.io/TrixiParticles.jl/dev) |
There was a problem hiding this comment.
I also added the docs badges. Note that the first one doesn't work yet, but will (hopefully) work in 2 days when the package is registered.
| [](https://join.slack.com/t/trixi-framework/shared_invite/zt-sgkc6ppw-6OXJqZAD5SPjBYqLd8MU~g) | ||
| [](https://www.youtube.com/@trixi-framework) |
There was a problem hiding this comment.
And I moved the social badges in front of the CI.
efaulhaber
force-pushed
the
fix-logos-readme2
branch
from
9ea55d6 to
0884ace
Compare
No description provided.