Boundary Pressure Calculation for FSI #498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svchb
requested review from
efaulhaber and
LasNikas
and removed request for
efaulhaber
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #498 +/- ##
==========================================
- Coverage 68.88% 68.73% -0.15%
==========================================
Files 86 86
Lines 5261 5278 +17
==========================================
+ Hits 3624 3628 +4
- Misses 1637 1650 +13
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
svchb
force-pushed
the
adami_pressure_changes
branch
from
da17b41 to
b82e338
Compare
Draft
Co-authored-by: Erik Faulhaber <[email protected]>
…mi_pressure_changes
efaulhaber
requested changes
Oct 22, 2024
efaulhaber
requested changes
Oct 30, 2024
Co-authored-by: Erik Faulhaber <[email protected]>
efaulhaber
approved these changes
Oct 30, 2024
LasNikas
added a commit
to LasNikas/TrixiParticles.jl
that referenced
this pull request
Nov 18, 2024
* change how adami pressure extrapolation is calculated and add optional offset * remove unused function * update * move to dispatch on function * fix * fix * format * fix test * format * change how adami pressure extrapolation is calculated and add optional offset * remove unused function * update * move to dispatch on function * fix * fix * format * fix test * format * fix merge * fix merge * fix * fix * fix * add new bnd density calculator * missing code * fix test * fix * fix * fix docs * fix * format * review comments * fix test * fix test * format * fix * update docs * fix * set test up for 1.11 * format * implement suggestions * fix equation * formatting * format * Increase errors for 1.11 * Fix invalidations * Fix tests * Update ci.yml * revert * Update ci.yml * Update test/validation/validation.jl Co-authored-by: Erik Faulhaber <[email protected]> * review comments * adjust docs * adjust docs * format * add complete equation * Update docs/src/systems/boundary.md Co-authored-by: Erik Faulhaber <[email protected]> --------- Co-authored-by: Erik Faulhaber <[email protected]> Co-authored-by: Niklas Neher <[email protected]>
LasNikas
added a commit
to LasNikas/TrixiParticles.jl
that referenced
this pull request
Nov 18, 2024
* change how adami pressure extrapolation is calculated and add optional offset * remove unused function * update * move to dispatch on function * fix * fix * format * fix test * format * change how adami pressure extrapolation is calculated and add optional offset * remove unused function * update * move to dispatch on function * fix * fix * format * fix test * format * fix merge * fix merge * fix * fix * fix * add new bnd density calculator * missing code * fix test * fix * fix * fix docs * fix * format * review comments * fix test * fix test * format * fix * update docs * fix * set test up for 1.11 * format * implement suggestions * fix equation * formatting * format * Increase errors for 1.11 * Fix invalidations * Fix tests * Update ci.yml * revert * Update ci.yml * Update test/validation/validation.jl Co-authored-by: Erik Faulhaber <[email protected]> * review comments * adjust docs * adjust docs * format * add complete equation * Update docs/src/systems/boundary.md Co-authored-by: Erik Faulhaber <[email protected]> --------- Co-authored-by: Erik Faulhaber <[email protected]> Co-authored-by: Niklas Neher <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the new BernoulliPressureExtrapolation on the right side
Depends on #599