Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add BoundaryModelTafuni #574

Draft
wants to merge 34 commits into
base: main
Choose a base branch
from

Merge branch 'main' into tafuni-open-boundaries

a8dc32e
Select commit
Loading
Failed to load commit list.
Draft

add BoundaryModelTafuni #574

Merge branch 'main' into tafuni-open-boundaries
a8dc32e
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Oct 31, 2024 in 1s

67.64% (-1.25%) compared to 550b95b

View this Pull Request on Codecov

67.64% (-1.25%) compared to 550b95b

Details

Codecov Report

Attention: Patch coverage is 12.17391% with 101 lines in your changes missing coverage. Please review.

Project coverage is 67.64%. Comparing base (550b95b) to head (a8dc32e).

Files with missing lines Patch % Lines
src/schemes/boundary/open_boundary/mirroring.jl 0.00% 88 Missing ⚠️
...oundary/open_boundary/method_of_characteristics.jl 46.15% 7 Missing ⚠️
src/schemes/boundary/open_boundary/system.jl 66.66% 4 Missing ⚠️
...rc/schemes/fluid/entropically_damped_sph/system.jl 0.00% 1 Missing ⚠️
src/schemes/fluid/fluid.jl 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #574      +/-   ##
==========================================
- Coverage   68.88%   67.64%   -1.25%     
==========================================
  Files          86       87       +1     
  Lines        5261     5365     +104     
==========================================
+ Hits         3624     3629       +5     
- Misses       1637     1736      +99

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov