-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add spell check and format check workflows #17
Add spell check and format check workflows #17
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 4 4
Lines 85 85
=========================================
Hits 85 85 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I just had one question about the new permissions set in the ci.yml
. Are these the ones that @sloede mentioned should be activated by default, which is why we do not set them in the Trixi ci?
Yes, @sloede mentioned that they should be activated by default. However, I observed some problems were old caches were not deleted so I wanted to try and set the permissions as suggested in https://github.com/julia-actions/cache |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
In the first new CI runs here the caches now get deleted. So it seems like setting the permissions explicitly was actually necessary. |
This PR introduces workflows for spell checking and format checking as done in
Trixi.jl
.Furthermore, the PR sets additional permissions in
ci.yml
that are probably needed to delete old caches.