Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add spell check and format check workflows #17

Merged
merged 9 commits into from
Jan 31, 2024

Conversation

patrickersing
Copy link
Contributor

This PR introduces workflows for spell checking and format checking as done in Trixi.jl.
Furthermore, the PR sets additional permissions in ci.yml that are probably needed to delete old caches.

Copy link

codecov bot commented Jan 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cd51eff) 100.00% compared to head (169e6ab) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #17   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         4           
  Lines           85        85           
=========================================
  Hits            85        85           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@andrewwinters5000 andrewwinters5000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I just had one question about the new permissions set in the ci.yml. Are these the ones that @sloede mentioned should be activated by default, which is why we do not set them in the Trixi ci?

@patrickersing
Copy link
Contributor Author

LGTM! I just had one question about the new permissions set in the ci.yml. Are these the ones that @sloede mentioned should be activated by default, which is why we do not set them in the Trixi ci?

Yes, @sloede mentioned that they should be activated by default. However, I observed some problems were old caches were not deleted so I wanted to try and set the permissions as suggested in https://github.com/julia-actions/cache

@andrewwinters5000 andrewwinters5000 marked this pull request as ready for review January 31, 2024 12:37
.github/workflows/FormatCheck.yml Outdated Show resolved Hide resolved
sloede
sloede previously approved these changes Jan 31, 2024
Copy link
Member

@sloede sloede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@andrewwinters5000 andrewwinters5000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@andrewwinters5000 andrewwinters5000 enabled auto-merge (squash) January 31, 2024 13:15
@andrewwinters5000 andrewwinters5000 merged commit 6bb65dd into trixi-framework:main Jan 31, 2024
9 checks passed
@patrickersing patrickersing deleted the update_ci branch February 1, 2024 08:18
@patrickersing
Copy link
Contributor Author

In the first new CI runs here the caches now get deleted. So it seems like setting the permissions explicitly was actually necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants