-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CI to Julia v1.10 #29
Update CI to Julia v1.10 #29
Conversation
I have adjusted the tolerances, such that all tests pass again. As the errors in the well-balanced tests are close to machine precision, I had to set the relative tolerance to |
Wouldn't it be enough to only adjust the absolute tolerances on the well-balancing tests? The relative tolerances in the julia> val1 = 4.998482888288039e-11
4.998482888288039e-11
julia> val2 = 4.704673109537872e-11
4.704673109537872e-11
julia> abs(val1-val2)
2.938097787501668e-12
julia> 1.4901161193847656e-8 * max( abs(val1), abs(val2) )
7.448319924306928e-19
julia> isapprox(val1, val2; atol = 1e-11)
true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I would say we wait for #28 to get merged and then we can update the testing
Sounds good! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #29 +/- ##
==========================================
- Coverage 99.52% 99.38% -0.14%
==========================================
Files 40 40
Lines 1459 1459
==========================================
- Hits 1452 1450 -2
- Misses 7 9 +2 ☔ View full report in Codecov by Sentry. |
@andrewwinters5000 this should now be ready to merge |
No description provided.