-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Speed up CI tests #42
Conversation
This is a good idea to make the CI faster. Should we already drop back the |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #42 +/- ##
=======================================
Coverage 99.22% 99.22%
=======================================
Files 45 45
Lines 1680 1680
=======================================
Hits 1667 1667
Misses 13 13 ☔ View full report in Codecov by Sentry. |
I think this will not be necessary, since in this setup we would no longer do coverage testing on |
Ah, gotcha. Then this sounds doubly good if it provides a workaround for the issues encountered on Mac-ARM. |
This provides a good speedup from the single job tests that previously ran for over 30min. |
That might be for the best, especially because it avoids the need to adjust the tolerances for the wet/dry well-balancedness tests on macOS which I see are failing due to round-off differences. |
Okay, I have restricted |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for speeding up the CI testing. I think we need to change the branch protections to reflect the new structure instead of the tests like Julia 1.10 - macOS-latest - x64 - pull_request
that no longer exist.
Co-authored-by: Michael Schlottke-Lakemper <[email protected]>
Yes, branch protection still needs to be updated. Can you take care of this? I don't have sufficient rights. |
With the additional features being added having a single CI job became very slow.
This PR should speed up the CI time by splitting the tests into multiple jobs. Furthermore,
macOS
andwindows
tests will run without coverage and become restricted to theupstream
testset.