-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update NC-fluxes for the SWE-Wet/Dry #53
Update NC-fluxes for the SWE-Wet/Dry #53
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes to code look good and it all should work. Because the CI will not run until Trixi v0.8.7 is released did you run the tests locally that everything passes?
Yes, I checked that the tests pass locally. |
I'll re-open this to trigger CI again using the new release of Trixi.jl |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #53 +/- ##
==========================================
- Coverage 99.27% 99.27% -0.01%
==========================================
Files 61 61
Lines 2638 2630 -8
==========================================
- Hits 2619 2611 -8
Misses 19 19 ☔ View full report in Codecov by Sentry. |
Thanks! Looks like it works. It would be great to get a new release including this somewhat soon so that Trixi.jl downstream CI passes again. |
846f4a1
into
trixi-framework:main
In trixi-framework/Trixi.jl#2038, the definition of
flux_nonconservative_wintermeyer_etal
has been changed and the methodflux_nonconservative_ersing_etal
is removed fromTrixi.jl
.Therefore in this PR
flux_nonconservative_ersing_etal
is now exported byTrixiShallowWater.jl
and some test values had to be updated. Sinceflux_nonconservative_ersing_etal
moves to TrixiShallowWater.jl the lower compat bound forTrixi.jl
is also updated.Needs to be merged after trixi-framework/Trixi.jl#2038