-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Setup initial documentation #54
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #54 +/- ##
=======================================
Coverage 99.27% 99.27%
=======================================
Files 60 60
Lines 2626 2626
=======================================
Hits 2607 2607
Misses 19 19 ☔ View full report in Codecov by Sentry. |
This project has benefited from funding from [Vetenskapsrådet](https://www.vr.se) | ||
(VR, Swedish Research Council), Sweden | ||
through the VR Starting Grant "Shallow water flows including sediment transport and morphodynamics", | ||
VR grant agreement 2020-03642 VR. | ||
|
||
**Note: This repository is still in its alpha stage and anything might change at |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This part should be removed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you refer to the note about being in alpha stage or the acknowledgements?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The alpha stage. Most parts should be relatively stable as far as I have observed, and the remaining breaking changes can be reflected by new version numbers. This should at least be the case when the package is kind of "published officially".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Definitely, I agree. We can ditch this alpha stage note. We just got confused whether or not you meant the statement acknowledging VR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry - I couldn't comment only on the alpha stage part since it was not changed directly in this PR 🙈
This PR creates the initial documentation for
TrixiShallowWater.jl
.ToDo: