Add Roe dissipation for SWE #73
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #73 +/- ##
==========================================
+ Coverage 99.28% 99.30% +0.01%
==========================================
Files 60 60
Lines 2652 2716 +64
==========================================
+ Hits 2633 2697 +64
Misses 19 19 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Convergence results for
Convergence results for
|
andrewwinters5000
requested changes
Mar 7, 2025
| dissipation_roe(u_ll, u_rr, orientation_or_normal_direction, | ||
| equations::ShallowWaterEquationsWetDry1D) | ||
| Roe-type dissipation term for the [`ShallowWaterEquationsWetDry1D`](@ref). To create the classical Roe solver, | ||
| this dissipation term can be combined with [`Trixi.flux_central`](@extref) using [`Trixi.FluxPlusDissipation`](@extref). |
There was a problem hiding this comment.
Suggested change
| this dissipation term can be combined with [`Trixi.flux_central`](@extref) using [`Trixi.FluxPlusDissipation`](@extref). | |
| this dissipation term can be combined with [`Trixi.flux_central`](@extref) using [`Trixi.FluxPlusDissipation`](@extref). | |
| For details on the Roe linearization see Chapter 15.3.2 and Chapter 15.3.3 for the one-dimensional | |
| shallow water equations of the book: | |
| - Randall J. LeVeque (2002) | |
| Finite Volume Methods for Hyperbolic Problems | |
| [DOI: 10.1017/CBO9780511791253](https://doi.org/10.1017/CBO9780511791253) |
| dissipation_roe(u_ll, u_rr, orientation_or_normal_direction, | ||
| equations::ShallowWaterEquationsWetDry2D) | ||
| Roe-type dissipation term for the [`ShallowWaterEquationsWetDry2D`](@ref). To create the classical Roe solver, | ||
| this dissipation term can be combined with [`Trixi.flux_central`](@extref) using [`Trixi.FluxPlusDissipation`](@extref). |
There was a problem hiding this comment.
Suggested change
| this dissipation term can be combined with [`Trixi.flux_central`](@extref) using [`Trixi.FluxPlusDissipation`](@extref). | |
| this dissipation term can be combined with [`Trixi.flux_central`](@extref) using [`Trixi.FluxPlusDissipation`](@extref). | |
| For details on the Roe linearization see Chapter 15.3.2 and Chapter 21.7 for the two-dimensional | |
| shallow water equations of the book: | |
| - Randall J. LeVeque (2002) | |
| Finite Volume Methods for Hyperbolic Problems | |
| [DOI: 10.1017/CBO9780511791253](https://doi.org/10.1017/CBO9780511791253) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a Roe dissipation term for the
ShallowWaterEquationsWetDry1DandShallowWaterEquationsWetDry2D. The dissipation term can be combined usingFlusPlusDissipation(flux_central, dissipation_roe)to obtain the classical Roe flux.