Skip to content

Commit

Permalink
Set version bounds for Trixi.jl to ensure compatibility (#86)
Browse files Browse the repository at this point in the history
* Fix Trixi version

* Change README.md

* Minor fix
  • Loading branch information
huiyuxie authored Dec 7, 2024
1 parent ded2864 commit 098acc2
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 7 deletions.
4 changes: 1 addition & 3 deletions Project.toml
Original file line number Diff line number Diff line change
Expand Up @@ -9,15 +9,13 @@ CUDA = "052768ef-5323-5732-b1bb-66c8b64840ba"
SciMLBase = "0bca4576-84f4-4d90-8ffe-ffa030f20462"
StaticArrays = "90137ffa-7385-5640-81b9-e52037218182"
Trixi = "a7f1ee26-1774-49b1-8366-f1abc58fbfcb"
TrixiBase = "9a0f1c46-06d5-4909-a5a3-ce25d3fa3284"

[compat]
BenchmarkTools = "1"
CUDA = "5"
SciMLBase = "2"
StaticArrays = "1"
Trixi = "0.8, 0.9"
TrixiBase = "0.1"
Trixi = "0.8, 0.9.8 - 0.9.8"
julia = "1.10"

[extras]
Expand Down
2 changes: 2 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@

TrixiCUDA.jl offers CUDA acceleration for solving hyperbolic PDEs.

⚠️ **_Warning_**: Our package may not always be updated with the latest updates or improvements in Trixi.jl. Forcing an update of Trixi.jl as a dependency for TrixiCUDA.jl beyond the version bounds specified in `Project.toml` may cause unexpected errors.

*Update on Nov 21, 2024*:
- Due to the [issue](https://github.com/trixi-framework/Trixi.jl/issues/2108) from upstream with Trixi.jl and CUDA.jl in Julia v1.11, this package now supports only Julia v1.10. Using or developing this package with Julia v1.11 will result in precompilation errors. To fix this, downgrade to Julia v1.10. If you have any other problems, please file issues [here](https://github.com/trixi-gpu/TrixiCUDA.jl/issues).

Expand Down
8 changes: 4 additions & 4 deletions src/TrixiCUDA.jl
Original file line number Diff line number Diff line change
Expand Up @@ -33,15 +33,15 @@ using SciMLBase: ODEProblem, FullSpecialize

using StaticArrays: SVector

# Change to use the Base.log and Base.sqrt - need to be fixed to avoid outputs
set_log_type!("log_Base")
set_sqrt_type!("sqrt_Base")

# Include other source files
include("auxiliary/auxiliary.jl")
include("semidiscretization/semidiscretization.jl")
include("solvers/solvers.jl")

# Change to use the Base.log and Base.sqrt - need to be fixed to avoid outputs
set_log_type!("log_Base")
set_sqrt_type!("sqrt_Base")

# Export the public APIs
export SemidiscretizationHyperbolicGPU
export semidiscretizeGPU
Expand Down

0 comments on commit 098acc2

Please sign in to comment.