Feature/captioning calculator #1
Conversation
There was a problem hiding this comment.
@ghughes13 - Nice job. Just some follow questions and one minor nit pick on validation.
| value={formState.averageProgramsPerMonth} | ||
| handleInputChange={handleInputChange} | ||
| image="number.png" | ||
| min="0" |
There was a problem hiding this comment.
Nice call on adding validation to these form inputs. Would probably put 1 here as if you have no programs a month the calculator isn't going to spit out a very useful answer :)
| name="name" | ||
| id="name" | ||
| value={formState.name} | ||
| handleInputChange={handleInputChange} |
There was a problem hiding this comment.
Can you explain why your handling each individual input change? What are the pros / cons? What would be another approach?
| } | ||
| }; | ||
|
|
||
| const calcCaptionMinutes = () => { |
There was a problem hiding this comment.
Can you explain the pros / cons of doing the validation client side like this?
| @@ -0,0 +1,90 @@ | |||
| body { | |||
There was a problem hiding this comment.
Looks like your using a tailwind and some general styles? Can you explain why?
| @@ -1,5 +1,16 @@ | |||
| const baseConfig = | |||
There was a problem hiding this comment.
cool seeing it deployed. Thanks!
Feature: CC-XXXX
Notes: Adds functioning caption calculator for clients to get a rough idea of how many captioning minutes they'd need.
**First time using tailwind and remix so please be forgiving with any dumb mistakes I've made related to that. Deployed to Netlify if you'd like to see a live demo. There's still a lot of refactoring/polish I'd do if this was going to production, but it's at a prototype quality level. Happy to hop on a call and go over anything in more detail if you'd like.Demo: https://feature-captioning-calculator--startling-shortbread-4eadcc.netlify.app/
Desktop Image:
Mobile Image:
