efs removal and docs

troydieter · May 13, 2022 · 914b821 · 914b821
1 parent dca7779
commit 914b821
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/README.md b/README.md
@@ -94,7 +94,8 @@ Deployment of Lighthouse CI through AWS-CDK onto AWS Fargate.
 
 ## Noted cleanup
 
-1. You may need to clean up `EFS` filesystems when creating and destroying this CDK app (they may persist)
+1. ~~You may need to clean up `EFS` filesystems when creating and destroying this CDK app (they may persist)~~
+    > Per v1.2 - I've added the proper RemovalPolicy for the EFS FileSystem to Destroy after removal
 2. Check for any lingering `EIP`'s that may resided
 
 ## Useful commands

diff --git a/lib/lhci-stack.ts b/lib/lhci-stack.ts
@@ -1,4 +1,5 @@
 import * as cdk from 'aws-cdk-lib';
+import { RemovalPolicy } from 'aws-cdk-lib';
 import { Certificate, CertificateValidation, isDnsValidatedCertificate } from 'aws-cdk-lib/aws-certificatemanager';
 import * as ec2 from 'aws-cdk-lib/aws-ec2';
 import { Protocol } from 'aws-cdk-lib/aws-ec2';
@@ -24,7 +25,8 @@ export class LHCIStack extends cdk.Stack {
       encrypted: true,
       lifecyclePolicy: efs.LifecyclePolicy.AFTER_14_DAYS,
       performanceMode: efs.PerformanceMode.GENERAL_PURPOSE,
-      throughputMode: efs.ThroughputMode.BURSTING
+      throughputMode: efs.ThroughputMode.BURSTING,
+      removalPolicy: RemovalPolicy.DESTROY
     });