-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python documentation #416
Python documentation #416
Conversation
I see a few minor typos in the docstrings, and some docstrings look not too informative. @glicerico , will you have time to improve Python docstrings in this PR? If yes, please, make them as suggestions. |
@wenwei-dev , If you notice a corresponding issue in the C API docs, please feel free to fix / improve it there too. |
@Necr0x0Der There were too many changes to make in suggestions. |
Thanks, this seems to be convenient enough. I'll try to take a look in a few days. |
Great work. I didn't verify everything carefully, but looks good. I added a few minor comments. It would be nice to merge after resolving them. |
@luketpeterson , will you take a look, or is it ok to merge? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some of my comments are possibly a bit pedantic. But my main issue is whether we should be documenting (even if only in private methods) interoperation between HyperonPy and HyperonC. Documenting it might give people the sense that this is an intended use case, which, in my opinion, it certainly isn't.
Co-authored-by: luketpeterson <[email protected]>
Co-authored-by: luketpeterson <[email protected]>
Co-authored-by: luketpeterson <[email protected]>
Co-authored-by: luketpeterson <[email protected]>
Co-authored-by: luketpeterson <[email protected]>
Co-authored-by: luketpeterson <[email protected]>
Co-authored-by: luketpeterson <[email protected]>
Co-authored-by: luketpeterson <[email protected]>
Co-authored-by: luketpeterson <[email protected]>
Co-authored-by: luketpeterson <[email protected]>
Co-authored-by: luketpeterson <[email protected]>
Co-authored-by: luketpeterson <[email protected]>
Thanks, @luketpeterson , I've committed your suggestions. As for
I would care more about people who needs to make a deeper dive into the code, because something is missing in examples or even APIs now, rather than rare users who would really misuse this functionality. I don't claim that we should document interoperation between HyperonPy and HyperonC, but I wouldn't remove it if this documentation exists. |
I'm merging it. Any further improvements can be made in follow up PRs if needed. |
No description provided.