Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python documentation #416

Merged
merged 40 commits into from
Sep 14, 2023
Merged

Python documentation #416

merged 40 commits into from
Sep 14, 2023

Conversation

wenwei-dev
Copy link
Contributor

No description provided.

@Necr0x0Der Necr0x0Der self-requested a review September 2, 2023 11:14
@Necr0x0Der
Copy link
Collaborator

I see a few minor typos in the docstrings, and some docstrings look not too informative. @glicerico , will you have time to improve Python docstrings in this PR? If yes, please, make them as suggestions.

@luketpeterson
Copy link
Contributor

I see a few minor typos in the docstrings, and some docstrings look not too informative. @glicerico , will you have time to improve Python docstrings in this PR? If yes, please, make them as suggestions.

@wenwei-dev , If you notice a corresponding issue in the C API docs, please feel free to fix / improve it there too.

@glicerico
Copy link
Contributor

I see a few minor typos in the docstrings, and some docstrings look not too informative. @glicerico , will you have time to improve Python docstrings in this PR? If yes, please, make them as suggestions.

@Necr0x0Der There were too many changes to make in suggestions.
Not sure if it's the best way, but I created a PR to @wenwei-dev 's branch for this PR.
wenwei-dev#4

@Necr0x0Der
Copy link
Collaborator

I see a few minor typos in the docstrings, and some docstrings look not too informative. @glicerico , will you have time to improve Python docstrings in this PR? If yes, please, make them as suggestions.

@Necr0x0Der There were too many changes to make in suggestions. Not sure if it's the best way, but I created a PR to @wenwei-dev 's branch for this PR. wenwei-dev#4

Thanks, this seems to be convenient enough. I'll try to take a look in a few days.

@Necr0x0Der
Copy link
Collaborator

I see a few minor typos in the docstrings, and some docstrings look not too informative. @glicerico , will you have time to improve Python docstrings in this PR? If yes, please, make them as suggestions.

@Necr0x0Der There were too many changes to make in suggestions. Not sure if it's the best way, but I created a PR to @wenwei-dev 's branch for this PR. wenwei-dev#4

Great work. I didn't verify everything carefully, but looks good. I added a few minor comments. It would be nice to merge after resolving them.

Necr0x0Der
Necr0x0Der previously approved these changes Sep 14, 2023
@Necr0x0Der
Copy link
Collaborator

@luketpeterson , will you take a look, or is it ok to merge?

Copy link
Contributor

@luketpeterson luketpeterson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of my comments are possibly a bit pedantic. But my main issue is whether we should be documenting (even if only in private methods) interoperation between HyperonPy and HyperonC. Documenting it might give people the sense that this is an intended use case, which, in my opinion, it certainly isn't.

python/hyperon/atoms.py Outdated Show resolved Hide resolved
python/hyperon/atoms.py Outdated Show resolved Hide resolved
python/hyperon/atoms.py Outdated Show resolved Hide resolved
python/hyperon/atoms.py Outdated Show resolved Hide resolved
python/hyperon/atoms.py Outdated Show resolved Hide resolved
python/hyperon/base.py Outdated Show resolved Hide resolved
python/hyperon/base.py Outdated Show resolved Hide resolved
python/hyperon/base.py Outdated Show resolved Hide resolved
python/hyperon/base.py Outdated Show resolved Hide resolved
python/hyperon/base.py Outdated Show resolved Hide resolved
Co-authored-by: luketpeterson <[email protected]>
Necr0x0Der and others added 11 commits September 14, 2023 10:42
Co-authored-by: luketpeterson <[email protected]>
Co-authored-by: luketpeterson <[email protected]>
Co-authored-by: luketpeterson <[email protected]>
Co-authored-by: luketpeterson <[email protected]>
Co-authored-by: luketpeterson <[email protected]>
Co-authored-by: luketpeterson <[email protected]>
Co-authored-by: luketpeterson <[email protected]>
Co-authored-by: luketpeterson <[email protected]>
Co-authored-by: luketpeterson <[email protected]>
Co-authored-by: luketpeterson <[email protected]>
Co-authored-by: luketpeterson <[email protected]>
@Necr0x0Der
Copy link
Collaborator

Thanks, @luketpeterson , I've committed your suggestions. As for

But my main issue is whether we should be documenting (even if only in private methods) interoperation between HyperonPy and HyperonC. Documenting it might give people the sense that this is an intended use case, which, in my opinion, it certainly isn't.

I would care more about people who needs to make a deeper dive into the code, because something is missing in examples or even APIs now, rather than rare users who would really misuse this functionality. I don't claim that we should document interoperation between HyperonPy and HyperonC, but I wouldn't remove it if this documentation exists.

@Necr0x0Der
Copy link
Collaborator

I'm merging it. Any further improvements can be made in follow up PRs if needed.

@Necr0x0Der Necr0x0Der merged commit bb19975 into trueagi-io:main Sep 14, 2023
1 check passed
@vsbogd vsbogd mentioned this pull request Aug 16, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants