Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make variable_operation feature affect minimal MeTTa interpreter #576

Merged
merged 5 commits into from
Feb 9, 2024

Conversation

vsbogd
Copy link
Collaborator

@vsbogd vsbogd commented Feb 8, 2024

This is a hotfix. Better way of doing this is adding a function which modifies minimal MeTTa interpreter code in order to skip such evaluations in metta-call function.

luketpeterson
luketpeterson previously approved these changes Feb 8, 2024
Copy link
Contributor

@luketpeterson luketpeterson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks ok from my perspective

Necr0x0Der
Necr0x0Der previously approved these changes Feb 8, 2024
Necr0x0Der and others added 2 commits February 8, 2024 20:11
Infinite loop happens in case expression with variable operation is
interpreted. In such case it is returned without modification from query
and starts being interpreted again. For example in (cdr-atom ($A $B $C))
@vsbogd vsbogd dismissed stale reviews from luketpeterson and Necr0x0Der via 93e0b9f February 8, 2024 21:38
@vsbogd
Copy link
Collaborator Author

vsbogd commented Feb 8, 2024

Fixes #488 in 93e0b9f

@luketpeterson luketpeterson self-requested a review February 9, 2024 05:12
Copy link
Contributor

@ngeiswei ngeiswei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand the fix but I approve, thanks Vitaly.

@vsbogd vsbogd merged commit 74a6f90 into trueagi-io:main Feb 9, 2024
2 checks passed
@vsbogd vsbogd deleted the minimal-variable-operation branch February 9, 2024 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants