Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to Conan2 #756

Merged
merged 6 commits into from
Jul 31, 2024
Merged

Migrate to Conan2 #756

merged 6 commits into from
Jul 31, 2024

Conversation

vsbogd
Copy link
Collaborator

@vsbogd vsbogd commented Jul 29, 2024

Fixes #421, also fixes release scripts to support Python 3.12 which is a part of #584.
New build configs are incompatible with Conan 1.64, thus upgrade to Conan 2 is required to build the project.
CMake update is also required because cmake-conan is not compatible with CMake <3.24.
Release test results https://github.com/vsbogd/hyperon-experimental/actions/runs/10169067698

vsbogd added 2 commits July 29, 2024 12:16
cmake-conan allows Conan dependencies loading on invoking CMake without
manually run `conan install` command
@vsbogd vsbogd force-pushed the conan2 branch 4 times, most recently from 14782df to 52eb2c9 Compare July 29, 2024 11:07
Fix README.md, GitHub workflows, Dockerfile, Python package release
scripts
@vsbogd vsbogd force-pushed the conan2 branch 8 times, most recently from 54728c8 to b9696c7 Compare July 30, 2024 13:10
vsbogd added 2 commits July 30, 2024 23:09
Use fresh version of setuptools which is compatible with Python 3.12.
@vsbogd
Copy link
Collaborator Author

vsbogd commented Jul 30, 2024

@Necr0x0Der @luketpeterson I added you mainly to understand if these changes works correctly in your environment.

@Necr0x0Der
Copy link
Collaborator

@Necr0x0Der @luketpeterson I added you mainly to understand if these changes works correctly in your environment.

Seems to be working for me. It still takes the system version of Python instead of the pyenv version, but it didn't become worse, and it's a minor issue.

@vsbogd
Copy link
Collaborator Author

vsbogd commented Jul 31, 2024

Seems to be working for me. It still takes the system version of Python instead of the pyenv version, but it didn't become worse, and it's a minor issue.

At which point it takes the system version of Python? Could you copy a relevant part of the build log?

@Necr0x0Der
Copy link
Collaborator

At which point it takes the system version of Python? Could you copy a relevant part of the build log?

We can do this in a separate issue

@vsbogd vsbogd merged commit 43b7230 into trueagi-io:main Jul 31, 2024
2 checks passed
@vsbogd vsbogd deleted the conan2 branch July 31, 2024 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade build system to Conan 2
3 participants