current state of pretty print #771

DaddyWesker · 2024-09-13T06:28:14Z

Examples of pretty_prints in current state:

(= (abs $x) (if
		(> $x 0)
		$x (if
			(== $x 0)
			0 (* $x -1)
			)
		))

( = (response) (if
		(== (messages) (user "match world."))
		("Hi there")
		(("Bye"))
		))

(: gen_gpt_2 (-> String String Number Number Number String))
(= (gen_gpt_2 $start_text $run_name $temperature $top_k $length)
	((text-generation) "gen_gpt_2" "Query"
		(Kwargs (start_text $start_text)
			(run_name $run_name) (temperature $temperature)
			(top_k $top_k) (length $length))))

! (assertEqual
	(match &self
		(Parent Tom $x)
		$x)
	(empty)
	)

!(assertEqual
	(exercise_1_3 1 2 5)
	29)

(= (better-sqrt-iter $oldguess $guess $x)
	(if (better-good-enough? $oldguess $guess $x)
		$guess
		(better-sqrt-iter $guess (improve $guess $x) $x)
		))

(= (first-denomination $kinds-of-coins)
	(case $kinds-of-coins
		( (1 1) (2 5) (3 10) (4 25) (5 50) )
		))

(= (cc $amount $kinds-of-coins)
	(if (== $amount 0)
		1 (if
			(or (< $amount 0) (== $kinds-of-coins 0))
			0 (+ (cc $amount (- $kinds-of-coins 1))
				(cc (- $amount (first-denomination $kinds-of-coins)) $kinds-of-coins))
			)
		))

(= (timed-prime-test $n) (let*
		( (() (println! $n)) (() (let $curtime
					(timems!)
					(start-prime-test $n $curtime)
					)))
		() ))

(= (fixed-point-print $f $first-guess)
	(let $try
		(lambda2 $guess $self-try (let $next
				($f $guess)
				(let $close-enough?
					(lambda2 $v1 $v2 (< (Abs (- $v1 $v2))
							(tolerance)))
					(if
						($close-enough? $guess $next)
						$next (let*
							( (() (println! $next)) (() ($self-try $next $self-try)) )
							() )
						)
					)
				))
		($try $first-guess $try)
		))

(= (cond $com_list) (if
		(== $com_list ())
		(empty)
		(case
			(car-atom $com_list)
			( ((Else $res) $res) (($cond $res)
					(if $cond $res
						(cond (cdr-atom $com_list))
						)) )
			)
		))

Fixed return value

DaddyWesker · 2024-09-16T07:13:27Z

I've checked, code works if launched like this:

!(import! &self snet_io)

!(bind! &generative-lms
  (snet-sdk create_service_client "naint" "generative-lms"))

!(snet-sdk get_service_callers_text &generative-lms)

Necr0x0Der · 2024-09-16T14:15:33Z

python/hyperon/exts/snet_io/snet_gate.py

@@ -88,6 +88,8 @@ def __call__(self, command_a, *args_a):
            self.init_sdk()
        if command == 'get_service_callers':
            return args[0].generate_callers()
+        if command == 'get_service_callers_text':


there was no need to expose this function to metta

Ok, i removed those lines.

Necr0x0Der · 2024-09-16T14:15:52Z

python/hyperon/exts/snet_io/snet_gate.py

    def generate_callers_text(self):
-        # TODO: pretty print
-        return "\n".join([repr(e) for e in self.generate_callers()])
+        res = "\n".join([repr(e) for e in self.generate_callers()])


I don't see pretty-print is used here

My bad. It was used for a while, but then I've removed by mistake. Added.

Necr0x0Der · 2024-09-16T14:16:41Z

python/hyperon/exts/snet_io/snet_gate.py

-        # TODO: pretty print
-        return "\n".join([repr(e) for e in self.generate_callers()])
+        res = "\n".join([repr(e) for e in self.generate_callers()])
+        return [ValueAtom(res)]


there is no need to wrap the result of this function into atom since it is supposed as a pure Python function, and it can be called via py-dot from metta

Necr0x0Der · 2024-09-16T14:17:31Z

python/hyperon/exts/snet_io/snet_gate.py

@@ -137,9 +139,105 @@ def get_service_messages(self):
    def get_operation_atom(self):
        return OperationAtom(self.service_details[1], self)

+    def __pretty_print__(self, input_str):


pretty-print was supposed for adding to stdlib, but maybe it can remain here for now....

Sorry, I wasn't been aware of this. Where should I place it?

Necr0x0Der · 2024-09-16T14:18:16Z

python/hyperon/exts/snet_io/snet_gate.py

@@ -137,9 +139,105 @@ def get_service_messages(self):
    def get_operation_atom(self):
        return OperationAtom(self.service_details[1], self)

+    def __pretty_print__(self, input_str):
+        list_of_functions = ["if", "match", "let", "let*", "unify",


what is special about these functions?

Those are functions which could have several inner brackets inside their body. Probably I could forget some functions.

What's about just nested expressions like (* (- $x $y) (- $x $y))? What is the substantial difference?

I suspect that it is problematic to detect nested brackets in your approach, because you try to reformat a textual representation, so you need to re-parse it. If you'd started with atoms, it could be simpler...

DaddyWesker · 2024-09-23T04:53:23Z

Okay, so I've rewrote pretty_print so it takes atoms as input not string. Below are some examples of how pretty_print prints atoms into string. @Necr0x0Der check if it is fine with you (when you have time of course).

(: generate
	(-> String String))

(= (generate $request)
	(generative-lms "generate" "Query"
	 (Kwargs
			(request $request))))

(= (abs $x)
	(if (> $x 0) $x
		(if (== $x 0) 0
			(* $x -1))))

(= (response)
	(if (== (messages)
			(user "match world"))
		("Hi there")
		((Bye))))

(assertEqual
	(match &self
		(Parent Tom $x) $x)
	(empty))

(assertEqual
	(exercise_1_3 1 2 5) 29)

(= (better-sqrt-iter $oldguess $guess $x)
	(if (better-good-enough? $oldguess $guess $x) $guess
		(better-sqrt-iter $guess
			(improve $guess $x) $x)))

(= (first-denomination $kinds-of-coins)
	(case $kinds-of-coins
		((1 1) (2 5) (3 10) (4 25) (5 50))))

(= (cc $amount $kinds-of-coins)
	(if (== $amount 0) 1
		(if (or (< $amount 0)
				(== $kinds-of-coins 0)) 0
			(+ (cc $amount
					(- $kinds-of-coins 1))
				(cc (- $amount
						(first-denomination $kinds-of-coins)) $kinds-of-coins)))))

(= (timed-prime-test $n)
	(let* ((() (println! $n))
			(() (let $curtime
					(timems!)
					(start-prime-test $n $curtime))))
		()))

(= (fixed-point-print $f $first-guess)
	(let $try
		(lambda2 $guess $self-try
			(let $next
				($f $guess)
				(let $close-enough?
					(lambda2 $v1 $v2
						(< (Abs (- $v1 $v2))
							(tolerance)))
					(if ($close-enough? $guess $next) $next
						(let* ((() (println! $next))
								(() ($self-try $next $self-try)))
							()))))) ($try $first-guess $try)))

(= (cond $com_list)
	(if (== $com_list
			()) (empty) (case (car-atom $com_list)
			(((Else $res) $res)
				(($cond $res)
					(if $cond $res
						(cond (cdr-atom $com_list))))))))

Necr0x0Der · 2024-09-30T12:01:12Z

python/hyperon/exts/snet_io/snet_gate.py

@@ -139,14 +143,58 @@ def get_service_messages(self):
    def get_operation_atom(self):
        return OperationAtom(self.service_details[1], self)

+    def __pretty_print_atoms__(self, input_atoms):


I'd move this function out of ServiceCall and wouldn't introduce len_threshold and current_len as its fields.

Okay, where to move this function? As i remember, you've proposed to move it to stdlib. Should i place it there?

You can keep it in the same file for now. Just move it out of the class.

@Necr0x0Der Done.

Necr0x0Der · 2024-10-22T07:39:56Z

python/hyperon/exts/snet_io/snet_gate.py

+                  ValueAtom(f'unknown command {repr(command_a)}'))]
+
+len_threshold = 50
+current_len = 0


What will happen when the function is called twice? Will current_len behave correctly?

Well, it should be set to 0 (line 158 sets it to 0 after every subatom was processed). I'll check just to be sure.

@Necr0x0Der I've checked (though I needed to do some changes to init_sdk since snet-sdk was updated and now its init is slightly different, probably i need to make new pr for those changes?) and current_len is 0 on the start of pretty print. And it can be seen on line 154.

OK, but still... Are they used only in pretty_print_atoms and its subfunctions? In this case, it's better to not declare them as global, but rather introduce them in pretty_print_atoms and use nonlocal for them in subfunctions

I'll try this out. I haven't been aware of nonlocal. Of course it would be better to introduce them inside function I just wasn't been able to make them work correctly. If nonlocal will help, I'll push changes tomorrow.

@Necr0x0Der Okay, it works. Thank you. I've pushed new commit with changes regarding current_len and threshold

current_len and threshold into function

current state of pretty print

30034be

DaddyWesker requested a review from Necr0x0Der September 13, 2024 06:28

Update snet_gate.py

aabda12

Fixed return value

Necr0x0Der reviewed Sep 16, 2024

View reviewed changes

DaddyWesker and others added 7 commits September 16, 2024 17:29

Update snet_gate.py

e640f28

Update snet_gate.py

48e9bff

Update snet_gate.py

27f60b6

prettyp print is being rewritten

fda9c31

rewritten pretty print

557eaa8

merge with main

c173d54

Merge branch 'trueagi-io-main' into main

60d433a

DaddyWesker changed the base branch from experimental to main September 23, 2024 04:56

Innokenty added 2 commits September 23, 2024 07:57

remove redundant class var

7e38ebe

example of generate_callers_text's usage added

43f1919

Necr0x0Der reviewed Sep 30, 2024

View reviewed changes

Innokenty and others added 2 commits October 7, 2024 07:44

move pretty print from class to outer function

e4961b3

Merge branch 'trueagi-io:main' into main

8279ab8

Necr0x0Der reviewed Oct 22, 2024

View reviewed changes

DaddyWesker added 4 commits October 24, 2024 12:40

Merge branch 'trueagi-io:main' into main

1f0633d

Update snet_gate.py

290125d

current_len and threshold into function

Update snet_gate.py

ce7cba3

Merge branch 'trueagi-io:main' into main

a556576

Necr0x0Der approved these changes Oct 29, 2024

View reviewed changes

Necr0x0Der merged commit 6547067 into trueagi-io:main Oct 29, 2024
2 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

current state of pretty print #771

current state of pretty print #771

DaddyWesker commented Sep 13, 2024

DaddyWesker commented Sep 16, 2024 •

edited

Loading

Necr0x0Der Sep 16, 2024

DaddyWesker Sep 16, 2024

Necr0x0Der Sep 16, 2024

DaddyWesker Sep 16, 2024 •

edited

Loading

Necr0x0Der Sep 16, 2024

DaddyWesker Sep 16, 2024

Necr0x0Der Sep 16, 2024

DaddyWesker Sep 16, 2024

Necr0x0Der Sep 16, 2024

DaddyWesker Sep 16, 2024

Necr0x0Der Sep 16, 2024

Necr0x0Der Sep 16, 2024

DaddyWesker commented Sep 23, 2024

Necr0x0Der Sep 30, 2024

DaddyWesker Sep 30, 2024

Necr0x0Der Oct 3, 2024

DaddyWesker Oct 7, 2024

Necr0x0Der Oct 22, 2024

DaddyWesker Oct 22, 2024

DaddyWesker Oct 22, 2024

Necr0x0Der Oct 24, 2024

DaddyWesker Oct 24, 2024

DaddyWesker Oct 25, 2024

current state of pretty print #771

current state of pretty print #771

Conversation

DaddyWesker commented Sep 13, 2024

DaddyWesker commented Sep 16, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

DaddyWesker Sep 16, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

DaddyWesker commented Sep 23, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

DaddyWesker commented Sep 16, 2024 •

edited

Loading

DaddyWesker Sep 16, 2024 •

edited

Loading