-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BaseListeningAgent #793
Merged
Merged
BaseListeningAgent #793
Changes from 2 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
9f514ad
BaseListeningAgent
cc5215f
remove inheritance from BaseListeningAgent
d54c22f
Merge branch 'main' into add_listening_agent
Necr0x0Der 930d8ff
Merge branch 'main' of github.com:trueagi-io/hyperon-experimental int…
554f51c
Merge remote-tracking branch 'origin/add_listening_agent' into add_li…
960cad0
Merge branch 'main' of github.com:trueagi-io/hyperon-experimental int…
565337d
BaseListeningAgent with AgentObject as parent
92990dc
fix and add self.lock
a555ce5
set self.running correctly
2a9a687
Merge branch 'main' into add_listening_agent
Necr0x0Der File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It doesn't look like
BaseListeningAgent
will be used by itself. Why not create aListeningAgent
which inherits fromAgentObject
instead of inheritingAgentObject
fromBaseListeningAgent
? I'm not sure if the functionality fromBaseListeningAgent
is always needed and will not disturb some uses ofAgentObject
. InheritingListeningAgent
fromAgentObject
looks more flexible to me. Or am I missing something?