Use rust primitive types in Python runtime #809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This breaks c1_grounded_basic.metta because now < is not a part of Python stdlib. Rust < return Rust true value and it cannot be checked for equality with Python True value.
vsbogd
force-pushed
the
use-rust-primitive-types
branch
from
babe3ed to
34d1175
Compare
Add Number and Bool atom types to the C API. Add asserts to check that caller either use correct type or no type at all. Add unit test. Fix old unit tests.
vsbogd
force-pushed
the
use-rust-primitive-types
branch
from
34d1175 to
5d5586d
Compare
|
Fixes #797 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove Python numbers and boolean values from Python standard library and use Rust primitives.
Introduce
IncorrectArgumenterror to return from grounded operations to say interpreter that arguments of the operation cannot be matched properly. Interpreter doesn't reduce such operation similarly to the case when pure MeTTa function is not matched.Some improvements of the Rust stdlib modules structure.
Fixes #797