Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collapsable side panels #10

Open
wants to merge 21 commits into
base: main
Choose a base branch
from

Conversation

windmillcode0
Copy link

@windmillcode0 windmillcode0 commented Aug 22, 2024

can collapse right side bar seperate
can collapse main sidebar sepeartely
on side bar collaspe the main frame expands to fill the available space
vscode linter lints whitespace makes it appear I wrote more modules than I did

@windmillcode0 windmillcode0 changed the title Collapseable side panels Collapsable side panels Aug 22, 2024
@trueberryless
Copy link
Member

holy moly, my bad, i haven't looked at this repo for months, I feel honoured that this repo is getting supported by the community

nice idea of an addition, i will have to find some time to look into this, sry that it took so long...

@windmillcode0
Copy link
Author

Greetings this is me k_j_code in the discord we spoke about this a month back, and you said you were going to merge when you have time thats ok

@trueberryless
Copy link
Member

I'd like to try and run it locally, to see the changes live, however I get the weird Error: [ERROR] Cannot find module 'virtual:astro-icon' imported from 'D:/repos/conform-mode/node_modules/.pnpm/[email protected]/node_modules/astro-icon/components/Icon.astro' Stack trace: at nodeImport (file:///D:/repos/conform-mode/node_modules/.pnpm/[email protected][email protected]/node_modules/vite/dist/node/chunks/dep-BKbDVx1T.js:56262:25) at eval (D:/repos/conform-mode/node_modules/.pnpm/[email protected]/node_modules/astro-icon/components/Icon.astro:4:37)

Did you use pnpm or npm?

@trueberryless
Copy link
Member

can you maybe deactive the linter and commit again? if possible this would make it easier to review...

@windmillcode0
Copy link
Author

Greetings how would I go about deactivatating the linter?

@trueberryless
Copy link
Member

I'd really like to merge this PR but first I need to test it locally. Unfortunately, I have tested it multiple times and I always get an error with the astro-icon package. Node cant find the virtual module. Either Im doing something very stupid or I dont know. I cloned your repo, ran pnpm i and pnpm dev in the docs folder and get this error nonetheless:

[ERROR] Cannot find module 'virtual:astro-icon' imported from 'D:/repos/conform-mode/node_modules/.pnpm/[email protected]/node_modules/astro-icon/components/Icon.astro'
  Stack trace:
    at nodeImport (file:///D:/repos/conform-mode/node_modules/.pnpm/[email protected][email protected]/node_modules/vite/dist/node/chunks/dep-BKbDVx1T.js:56262:25)
    at eval (D:/repos/conform-mode/node_modules/.pnpm/[email protected]/node_modules/astro-icon/components/Icon.astro:4:37)

I have also tried to add the types from the package astro-icon but it doesnt work either...

Can you explain what this package does and maybe why it doesnt work on my machine... How did you manage to run it locally?

I feel kinda stupid asking these questions but I would love to integrate the functionality into this plugin but I cant just merge without testing...

@windmillcode0
Copy link
Author

windmillcode0 commented Oct 2, 2024

Greetings would you like to schedule time to join a zoom call to further debug? https://windmillcode.com/contact
It seems to work when astro-icon is installed in the consumer as well as the library I removed it from the consumer not sure why the library does not install it. Greetings Ill ping you in discord

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants