NAS-133109 / 25.04 / Refactor PAM config generation #15218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugclerk
changed the title
This commit refactors how we generate custom PAM configuration lines so as to force them to run though a parser, and adds tests for said parser. pam_tty_audit is also enabled for interactive sessions for root account if for some reason a user gets interactive root session when GPOS STIG is enabled (this should never happen).
bmeagherix
requested changes
Dec 16, 2024
src/middlewared/middlewared/etc_files/pam.d/common-session.mako
Outdated
Show resolved
Hide resolved
bmeagherix
reviewed
Dec 16, 2024
bmeagherix
approved these changes
Dec 17, 2024
bmeagherix
requested changes
Dec 18, 2024
| PAMLine( | ||
| pam_service=PAMService.AUTH, | ||
| pam_control=( | ||
| PAMControl(PAMResponse.SUCCESS, 2), |
There was a problem hiding this comment.
I think this should be
PAMControl(PAMResponse.SUCCESS, 1),
There was a problem hiding this comment.
I agree. 1 is what's used in current common-auth for a server attached to FreeIPA.
mgrimesix
requested changes
Dec 18, 2024
| PAMLine( | ||
| pam_service=PAMService.ACCOUNT, | ||
| pam_control=( | ||
| PAMControl(PAMResponse.SUCCESS, 2), |
There was a problem hiding this comment.
In current code, attached to the FreeIPA I see the following in common-account:
account [success=1 new_authtok_reqd=done default=ignore] pam_unix.so
Maybe this line should have 1 and not 2?
| PAMLine( | ||
| pam_service=PAMService.AUTH, | ||
| pam_control=( | ||
| PAMControl(PAMResponse.SUCCESS, 2), |
There was a problem hiding this comment.
I agree. 1 is what's used in current common-auth for a server attached to FreeIPA.
bmeagherix
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit refactors how we generate custom PAM configuration lines so as to force them to run though a parser, and adds tests for said parser. pam_tty_audit is also enabled for interactive sessions for root account if for some reason a user gets interactive root session when GPOS STIG is enabled (this should never happen).