NAS-131559 / 25.04 / Remove accepts style decorator from apps plugin #15225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugclerk
changed the title
creatorcary
reviewed
Dec 18, 2024
|
|
||
|
|
||
| class AppConfigResult(BaseModel): | ||
| result: AppConfig |
There was a problem hiding this comment.
To save the extra model this could be result: dict, same as AlertEntry.metadata unless we know at least one of the fields in AppConfig.
| result: AppEntry | ||
|
|
||
|
|
||
| class AppUpdate(BaseModel): |
There was a problem hiding this comment.
No ForUpdateMetaclass? Setting defaults here may clear out the fields not provided in the call params depending on how app.update updates the fields.
| pass | ||
|
|
||
|
|
||
| class AppContainerIDResult(BaseModel): |
There was a problem hiding this comment.
We should try and keep Args and Result model pairs together.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Removes accept style decorator from app plugin.