This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 678
feat: genesis dot json #3884
Draft
tenthirtyone
wants to merge
20
commits into
develop
Choose a base branch
from
feat/genesis-dot-json
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
feat: genesis dot json #3884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MicaiahReid
force-pushed
the
upgrade-ejs
branch
3 times, most recently
from
November 10, 2022 15:12
ecc0bc3
to
6d90786
Compare
MicaiahReid
force-pushed
the
tech-debt-dudes
branch
from
November 14, 2022 16:30
60af3f2
to
999adf7
Compare
Co-authored-by: David Murdoch <[email protected]>
tenthirtyone
force-pushed
the
feat/genesis-dot-json
branch
from
December 5, 2022 23:38
686ecfa
to
51d15ab
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a
genesisPath
option andj
switch to cli that takes in a path to agenesis.json
.Relevant Files
This branch has had some force pushin' The files who matter are
blockchain.ts
chain-options.ts
To use
npm run start -- -j ./genesis.json
Callouts
Using
process.cwd()
so running the above command in the top-level repo this will resolve topackages/ganache
Todo
Accounts
Side Effects from ganache default options
Questions
cross-option exclusions?
option requires?
Feasibility
resolving which hardfork is set
retro-setting ganache-options with genesis.json values where applicable (e.g. chainId)