Skip to content

Commit

Permalink
(Chore): Re-enable squawk linux arm tests (#877)
Browse files Browse the repository at this point in the history
Follow-up to #875. They now support it in
[v1.4.0](https://github.com/sbdchd/squawk/releases/tag/v1.4.0)!
  • Loading branch information
TylerJang27 authored Sep 26, 2024
1 parent 32ecb67 commit 0f4799e
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 5 deletions.
6 changes: 3 additions & 3 deletions linters/squawk/plugin.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,16 +4,16 @@ tools:
- name: squawk
runtime: node
package: squawk-cli
# First version to include Windows install.
known_good_version: 1.2.0
# First version to include Windows install and linux arm64
known_good_version: 1.4.0
shims: [squawk]
lint:
definitions:
- name: squawk
description: A linter for Postgres migrations
files: [sql]
tools: [squawk]
known_good_version: 1.2.0
known_good_version: 1.4.0
suggest_if: config_present
direct_configs: [.squawk.toml]
commands:
Expand Down
9 changes: 7 additions & 2 deletions linters/squawk/squawk.test.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,12 @@
import semver from "semver";
import { linterCheckTest } from "tests";

// No release for squawk on arm64 linux https://github.com/sbdchd/squawk/issues/372
// Squawk first supported linux arm in 1.4.0 https://github.com/sbdchd/squawk/issues/372
linterCheckTest({
linterName: "squawk",
skipTestIf: () => process.arch === "arm64" && process.platform === "linux",
skipTestIf: (version) =>
process.arch === "arm64" &&
process.platform === "linux" &&
version !== undefined &&
semver.lt(version, "1.4.0"),
});

0 comments on commit 0f4799e

Please sign in to comment.