Skip to content

Commit

Permalink
Don't autoenable gokart and tfsec (#470)
Browse files Browse the repository at this point in the history
We had originally been pretty aggressive in auto-enabling/suggesting
security linters, however there are 2 modifications that should no
longer be auto-enabled:
- tfsec is migrating to trivy, so we don't want to auto-enable tfsec
anymore
- gokart has the potential to
[fail](praetorian-inc/gokart#88) in a large
number of repos, for example
[failing](https://github.com/trunk-io/trunk-action/actions/runs/6156480974/job/16705375836?pr=186)
in the [tflint repo](https://github.com/terraform-linters/tflint), and
it's not very actively maintained, so for now we won't enable it
  • Loading branch information
TylerJang27 authored Sep 12, 2023
1 parent 6e694e9 commit 4bb9eb6
Show file tree
Hide file tree
Showing 4 changed files with 3 additions and 5 deletions.
2 changes: 1 addition & 1 deletion linters/gokart/plugin.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ lint:
- name: gokart
files: [go]
tools: [gokart]
suggest_if: files_present
suggest_if: config_present
environment:
- name: PATH
list: ["${linter}"]
Expand Down
2 changes: 1 addition & 1 deletion linters/gokart/test_data/go.mod
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
module gokart_linter_test

go 1.19
go 1.21.1
2 changes: 1 addition & 1 deletion linters/tfsec/plugin.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ lint:
files: [terraform]
tools: [tfsec]
known_good_version: 1.28.1
suggest_if: files_present
suggest_if: never
commands:
- name: lint
output: sarif
Expand Down
2 changes: 0 additions & 2 deletions tests/repo_tests/config_check.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,6 @@ describe("Global config health check", () => {
"dotenv-linter",
"git-diff-check",
"gofmt",
"gokart",
"golangci-lint",
"hadolint",
"haml-lint",
Expand All @@ -168,7 +167,6 @@ describe("Global config health check", () => {
"taplo",
"terrascan",
"tflint",
"tfsec",
"trivy",
"trufflehog",
"yamllint",
Expand Down

0 comments on commit 4bb9eb6

Please sign in to comment.