Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Memoize lfs check which was very expensive. #53

Merged
merged 1 commit into from
Nov 11, 2024
Merged

Memoize lfs check which was very expensive. #53

merged 1 commit into from
Nov 11, 2024

Conversation

EliSchleifer
Copy link
Member

@EliSchleifer EliSchleifer commented Nov 11, 2024 •
edited
Loading

The LFS check should only be performed when necessary since it hits the file system and we should memorize the result so we don't keep repinging it.

@EliSchleifer EliSchleifer marked this pull request as ready for review November 11, 2024 21:29
@trunk-io Trunk.io
Copy link

trunk-io bot commented Nov 11, 2024

29 tests were run on 209a7208. ✅ 29 Passed. View Full Report ↗︎

settings

TylerJang27
TylerJang27 approved these changes Nov 11, 2024
View reviewed changes
Copy link
Collaborator

@TylerJang27 TylerJang27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EliSchleifer EliSchleifer merged commit 4185c74 into main Nov 11, 2024
4 checks passed
@EliSchleifer EliSchleifer deleted the eli/fix-toolbox-perf branch November 11, 2024 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TylerJang27 TylerJang27 TylerJang27 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EliSchleifer @TylerJang27