Add "no-curly-quotes" rule to the codebase. #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TylerJang27
reviewed
Nov 20, 2024
src/rules/no_curly_quotes.rs
Outdated
Comment on lines
23
to
25
| if run.is_upstream() { | ||
| return Ok(vec![]); | ||
| } |
There was a problem hiding this comment.
What's wrong with running this on the upstream and having it behave like a normal linter? This shouldn't need upstream awareness like ICTC does...
There was a problem hiding this comment.
I had disabled that for testing - good catch
shoudve put in a donotand
| path: path.to_str().unwrap().to_string(), | ||
| range: Some(Range { | ||
| start: Position { | ||
| line: i as u64, |
There was a problem hiding this comment.
Are the replacements 1-indexed and the diagnostics are 0-indexed?
There was a problem hiding this comment.
If not, the test you added asserts the message, not the diagnostic location
There was a problem hiding this comment.
good catch - I shoud standardize this in the diagnostics.rs file where we make every 1 index assuming input is 0 except for startLine and endLine...whoops.
TylerJang27
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for nocurlyquotes that will find instances of curlyquotes in a file and replace with correct non-curly form. We had instances of this in our code base and it caused some issues with marketing site.
Fun little rule. Interestingly - this rule exposes a bug in how we apply on
trunk checksarif fixes for utf-8 non-ascii characters. For now this rule will stay disabled until we have a fix.Fix bug where multiple fixes in a single issue were being turned into multiple issues (which is not what the spec or code was intending to do).