Refactor service and remove clients-? features #194
+243
−411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trussed is intended to be executed in a separate task. Implementing Syscall for Service directly should not be necessary and makes the types more complex. Instead, hardware runners should use interrupts and software runners should use channels (like in trussed::virt) to communicate with the service. If necessary, a wrapper struct can be used for the old behavior.
It is easier to construct the required components separately than to use a helper struct that tries to combine all requirements into one type.
This patch decouples the Service from the ServiceEndpoint instances. This gives us more flexibility when constructing the clients and removes the need for the hard-coded client count in Service.
As the Service no longer owns the ServiceEndpoints, we can allow arbitrary lifetimes for the channels. This also removes the need for the global interchange so it is removed from the crate.
As the Service no longer stores the endpoints itself and the TrussedInterchange is no longer needed, we don’t need the client count anymore in Trussed. This means we can remove the client-? features.
sosthene-nitrokey
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the
Servicesetup:Serviceno longer stores theServiceEndpoints. Instead they are passed by the runner toService::process. This decouples the different Trussed components and removes the need for knowing the number of clients inService.interchange::Channels are now provided by the runner, removing the need forTrussedInterchangewith a fixed number of clients.clients-?features.ClientBuilderis also removed as it just adds complexity by combining different requirements into one type.