feat: add DateSelector dateFormat prop #2726
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lpsinger
force-pushed
the
dateFormat
branch
2 times, most recently
from
5a98f48
to
86034fb
Compare
lpsinger
changed the title
werdnanoslen
reviewed
Feb 7, 2024
Go for it! |
Pardon the accidental close, here's the commit |
|
Any update on this? |
Just waiting on code reviews from our engineers (for this and the other PRs), pardon the delay |
lpsinger
added a commit
to lpsinger/gcn.nasa.gov
that referenced
this pull request
May 27, 2024
- uswds/uswds#5825 has been fixed. - https://github.com/lpsinger/react-uswds/tree/gcn is the same as trussworks/react-uswds#2726, but rebased. - I had to update some CSS where we have heavily customized the appearance of some USWDS components.
|
I fixed a form validation bug. Please review again. |
dakota002
reviewed
May 28, 2024
lpsinger
added a commit
to lpsinger/gcn.nasa.gov
that referenced
this pull request
May 31, 2024
- uswds/uswds#5825 has been fixed. - https://github.com/lpsinger/react-uswds/tree/gcn is the same as trussworks/react-uswds#2726, but rebased. - I had to update some CSS where we have heavily customized the appearance of some USWDS components.
lpsinger
added a commit
to nasa-gcn/gcn.nasa.gov
that referenced
this pull request
Jun 1, 2024
- uswds/uswds#5825 has been fixed. - https://github.com/lpsinger/react-uswds/tree/gcn is the same as trussworks/react-uswds#2726, but rebased. - I had to update some CSS where we have heavily customized the appearance of some USWDS components.
|
I rebased this again. Any updates on when someone will review this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related Issues or PRs
How To Test
Screenshots (optional)