Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Package List - Filtering #951

Closed
carlosthe19916 opened this issue Oct 30, 2024 · 3 comments · Fixed by #1073
Closed

Package List - Filtering #951

carlosthe19916 opened this issue Oct 30, 2024 · 3 comments · Fixed by #1073
Assignees
@jcrossley3
Labels
UI-V1 parity Tasks needed to get done for V1 UI parity

Comments

@carlosthe19916
Copy link
Member

This is how it looks V1 Package List page:

Screenshot From 2024-10-30 16-25-07

  • In v2 UI I am using the endpoint /api/v1/purl for populating the table in the UI.

There are 2 main filters I need to implement in V2.

  • Type Filter:
    • I am currently using q=type=maven|rpm|npm|oci and it works! So I guess there is nothing to do on that.
  • Architecture Filter:
    • I was not able to make it work with q=arch=x86_64|aarch64|ppc64le|s390x|noarch so would you advice me how to filter by Architecture?
@carlosthe19916 carlosthe19916 added the UI-V1 parity Tasks needed to get done for V1 UI parity label Oct 30, 2024
@jcrossley3
Copy link
Contributor

  • I am currently using q=type=maven|rpm|npm|oci and it works! So I guess there is nothing to do on that.

Yay!

  • I was not able to make it work with q=arch=x86_64|aarch64|ppc64le|s390x|noarch so would you advice me how to filter by Architecture?

Boo! I'll investigate.

@jcrossley3 jcrossley3 self-assigned this Oct 30, 2024
@jcrossley3 jcrossley3 moved this to Backlog in Trustify Nov 4, 2024
@jcrossley3 jcrossley3 moved this from Backlog to In progress in Trustify Dec 4, 2024
jcrossley3 added a commit to jcrossley3/trustify that referenced this issue Dec 5, 2024
@jcrossley3
fix: enable filtering/sorting on qualified purl json fields
6a34c9a 
Fixes trustification#888
Fixes trustification#951
Fixes trustification#972

Signed-off-by: Jim Crossley <[email protected]>
@jcrossley3 jcrossley3 mentioned this issue Dec 5, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Dec 6, 2024
@jcrossley3
fix: enable filtering/sorting on qualified purl json fields
910c378 
Fixes #888
Fixes #951
Fixes #972

Signed-off-by: Jim Crossley <[email protected]>
@jcrossley3
Copy link
Contributor

@carlosthe19916 when #1073 merges, this should work as you expect: q=type=maven|rpm&arch=x86_64|noarch

Regarding type, keep in mind that type=maven (not pom) for the following purl: pkg:maven/org.apache.xmlgraphics/[email protected]?type=pom

If we need to query type as a purl qualifier, we'll need to introduce a non-conflicting name for the purl's type, e.g. we use ty in the db.

Speaking of qualifiers, these are the only ones we currently support: arch, distro, and repository_url. But it's trivial to add more.

@carlosthe19916
Copy link
Member Author

Awesome! Thanks @jcrossley3 I tested your PR and it worked as a charm.

We can close this issue as completed I think

@github-project-automation github-project-automation bot moved this from In progress to Done in Trustify Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jcrossley3 jcrossley3

Labels
UI-V1 parity Tasks needed to get done for V1 UI parity
Projects
Trustify
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: enable filtering/sorting on qualified purl json fields jcrossley3/trustify
2 participants
@jcrossley3 @carlosthe19916