fix: enable filtering/sorting on qualified purl json fields #1073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes trustification#888 Fixes trustification#951 Fixes trustification#972 Signed-off-by: Jim Crossley <[email protected]>
Signed-off-by: Jim Crossley <[email protected]>
Signed-off-by: Jim Crossley <[email protected]>
Signed-off-by: Jim Crossley <[email protected]>
Signed-off-by: Jim Crossley <[email protected]>
This required us to fix the filter logic so that translation occurs before fetching the field's column metadata. Signed-off-by: Jim Crossley <[email protected]>
Signed-off-by: Jim Crossley <[email protected]>
JimFuller-RedHat
approved these changes
Dec 6, 2024
ctron
approved these changes
Dec 6, 2024
carlosthe19916
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #888
Fixes #951
Fixes #972
This introduces some potential naming conflicts, specifically that
typeis a valid PURL qualifier as well as an attribute of the PURL itself, therefore we currently aliastytotype, which effectively prohibits using thetypequalifier in queries; only the type of the PURL itself may be used.We need to decide which qualifiers we want to support.