Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: move number_of_packages to SbomHead #1021

Merged
merged 4 commits into from
Nov 21, 2024
Merged

fix: move number_of_packages to SbomHead #1021

merged 4 commits into from
Nov 21, 2024

Conversation

jcrossley3
Copy link
Contributor

Fixes #1006 by making the sbom #packages available in /api/v1/vulnerability/{id} as well as /api/v1/sbom/{id}

@ctron
Copy link
Contributor

ctron commented Nov 20, 2024

I think was added by a request from the UI: #975 So is moving this breaking the other case? Or did I get something wrong?

@jcrossley3
Copy link
Contributor Author

I think was added by a request from the UI: #975 So is moving this breaking the other case? Or did I get something wrong?

I don't think you went quite far enough with #975, which is why #1006 was created. The #packages is required not only from /api/v1/sbom/{id} but also in the nested sboms returned by /api/v1/vulnerability/{id}. This PR should add the latter without affecting the former, but I'll add some tests to confirm.

@jcrossley3 jcrossley3 requested a review from ctron November 20, 2024 16:23
@jcrossley3
fix: move number_of_packages to SbomHead
b65b35f 
Fixes trustification#1006 by making the sbom #packages available in
/api/v1/vulnerability/{id} as well as /api/v1/sbom/{id}

Signed-off-by: Jim Crossley <[email protected]>
@jcrossley3
fix: openapi spec for moved number_of_packages
72312fc 
Signed-off-by: Jim Crossley <[email protected]>
@jcrossley3
Add tests affirming number_of_packages returned properly
8d83639 
Among other things

Signed-off-by: Jim Crossley <[email protected]>
@jcrossley3
I learned a new trick!
f51f8d7 
Signed-off-by: Jim Crossley <[email protected]>
@ctron
Copy link
Contributor

ctron commented Nov 21, 2024

I think was added by a request from the UI: #975 So is moving this breaking the other case? Or did I get something wrong?

I don't think you went quite far enough with #975, which is why #1006 was created. The #packages is required not only from /api/v1/sbom/{id} but also in the nested sboms returned by /api/v1/vulnerability/{id}. This PR should add the latter without affecting the former, but I'll add some tests to confirm.

Ah ok. Got it.

@jcrossley3 jcrossley3 added this pull request to the merge queue Nov 21, 2024
Merged via the queue into trustification:main with commit 6b9e758 Nov 21, 2024
3 checks passed
@jcrossley3 jcrossley3 deleted the 1006 branch November 21, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ctron ctron ctron approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Package count is missing from nested sboms returned from /api/v1/vulnerability/{id}
2 participants
@jcrossley3 @ctron