-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CycloneDX 1.6 PoC #1076
CycloneDX 1.6 PoC #1076
Conversation
c14b342
to
cae7c74
Compare
Not that I think we should overload this PR to implement 'all the things'... but a little foreshadowing ;) tldr on cdx 1.6 support for prodsec:
|
2575643
to
cd26af6
Compare
I think we should discuss if we want to merge this, or not. I know it doesn't add any new data extraction, only allows to actually parse CDX 1.6. |
The one thing I am not sure about is, it it is good enough to only parse using the 1.6 structures. All our tests (which are pre 1.6) pass. So it looks ok. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We got clarification that we are only interested (for now) in the software composition capabilities of cdx1.6 (eg. not AIBOM, CBOM, etc) - I think this is a important step - we take earlier rather then later - LGTM
I guess we have some gaps in our testing because this doesn't seem correct in light of this PR. |
Indeed. |
@jcrossley3 added a test for this, and fixed the detection. |
bca5f75
to
03f4abc
Compare
Here's a PoC, trying to leverage a different parsing library for the CycloneDX SBOMs. It supports 1.6 and has a simpler approach to generating the structs from the schema. Thus I'd expect less delays with future versions.
Just to be clear, this doesn't extract any of the new 1.6 information. It just ensures we can parse such files.