Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Score" => "Severity" conversion to be done in the backend and not in the UI #45

Merged
merged 1 commit into from
Mar 9, 2024

Conversation

carlosthe19916
Copy link
Member

@carlosthe19916 carlosthe19916 commented Mar 9, 2024

Addressing comments made in #20

  • Address comments about "Score" => "Severity" conversion to be done in the backend and not in the UI
  • Enhance SeverityShieldAndText component: replace "showLabel" by "hideLabel". The label will be shown by default (this represent the majority of cases in the UI) and only when hideLabel is present the "label" will be hidden

@github-actions github-actions bot added the frontend Frontend related code changes label Mar 9, 2024
@carlosthe19916 carlosthe19916 changed the title Address pr-20 comments "Score" => "Severity" conversion to be done in the backend and not in the UI Mar 9, 2024
@carlosthe19916 carlosthe19916 merged commit 896972a into trustification:main Mar 9, 2024
3 checks passed
@carlosthe19916 carlosthe19916 deleted the address-pr-20 branch December 30, 2024 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend Frontend related code changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant